1 comment:
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
Patch Set #2, Line 76: case ADL_P_LP4_1:
I would agree in other cases, but I'd say this case is pretty self-explanatory already. […]
It's an old habit of mine that would give you a heuristic to catch unintended fallthroughs. This case isn't too bad, but I will also note that C++17 added support for a [[fallthrough]] attribute, which I think you can finagle into an error if the compiler catches an unmarked one. I guess code review is our tool to make sure things like this are correct here.
To view, visit change 47054. To unsubscribe, or for help writing mail filters, visit settings.