Change in coreboot[master]: mb/google/hatch/variants/helios: Modify touchscreen power on sequence
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35907 )
Change subject: mb/google/hatch/variants/helios: Modify touchscreen power on sequence ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35907/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35907/2//COMMIT_MSG@13 PS2, Line 13: TEST
Also, looking at the values, they do not match the timings in that data sheet. […]
Done
https://review.coreboot.org/c/coreboot/+/35907/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35907/5//COMMIT_MSG@13 PS5, Line 13: Add GPP_C4 setting.
- Please mention the exact values you change it to. […]
Done
https://review.coreboot.org/c/coreboot/+/35907/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35907/2/src/mainboard/google/hatch/... PS2, Line 113: register "generic.stop_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)" : register "generic.stop_delay_ms" = "15" : register "generic.stop_off_delay_ms" = "5"
GPP_C4 need to set high in gpio.c . […]
Done
https://review.coreboot.org/c/coreboot/+/35907/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35907/5/src/mainboard/google/hatch/... PS5, Line 106: register "generic.reset_delay_ms" = "120"
Kane can you please revert this change until the next build as Philip requested?
Done
-
Shelley Chen (Code Review)