Change in coreboot[master]: mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

24 Apr 2020 24 Apr '20

5:36 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tuning i2c frequency for jinlon: I2C0: 392.7 KHz I2C1: 390 KHz I2C3: unused I2C4: 388.8 KHz

BUG=b:154900217 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40688/1

diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 7cf434d..92faf88 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -46,15 +46,21 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 30, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 20, + .fall_time_ns = 25, }, .i2c[3] = { .speed = I2C_SPEED_FAST, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 40, + .fall_time_ns = 60, }, }"

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Chen Wisley (Code Review)

24 Apr 24 Apr

5:37 a.m.

Chen Wisley has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tuning i2c frequency for jinlon: I2C0: 392.7 KHz I2C1: 390 KHz I2C3: unused I2C4: 388.8 KHz

BUG=b:154900217 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40688/2

Tim Wawrzynczak (Code Review)

11:44 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@7 PS2, Line 7: goog google

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@17 PS2, Line 17: emerge-hatch coreboot chromeos-bootimage I'm guessing the actual test was to measure the frequencies with a scope?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Apr 2020 17:44:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

11:57 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/goog/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@17 PS2, Line 17: emerge-hatch coreboot chromeos-bootimage

...

I'm guessing the actual test was to measure the frequencies with a scope?

Yes, please provide more detail. You built the coreboot image, installed it on a DUT and then? Measured the clock signal with a scope? Ran a test that has previously failed because the target devices don't work reliably above 400 KHz?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Fri, 24 Apr 2020 17:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Wisley Chen (Code Review)

11:14 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tuning i2c frequency for jinlon: I2C0: 392.7 KHz I2C1: 390 KHz I2C3: unused I2C4: 388.8 KHz

BUG=b:154900217 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40688/3

Wisley Chen (Code Review)

11:16 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Wisley Chen has uploaded a new patch set (#4) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tuning i2c frequency for jinlon: I2C0: 392.7 KHz I2C1: 390 KHz I2C3: unused I2C4: 388.8 KHz

BUG=b:154900217 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage, and measured with scope

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40688/4

Wisley Chen (Code Review)

11:18 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@7 PS2, Line 7: goog

...

google

Done

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@17 PS2, Line 17: emerge-hatch coreboot chromeos-bootimage

...

Yes, please provide more detail. […]

Yes, our ee guy measured the clock with a scope.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 05:18:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Gerrit-MessageType: comment

Wisley Chen (Code Review)

11:34 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@17 PS2, Line 17: emerge-hatch coreboot chromeos-bootimage

...

Yes, our ee guy measured the clock with a scope.

I didn't see device failed before tuning. But we need to tune it to meet spec.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 05:34:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Comment-In-Reply-To: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: comment

Wisley Chen (Code Review)

11:34 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40688/2//COMMIT_MSG@17 PS2, Line 17: emerge-hatch coreboot chromeos-bootimage

...

I didn't see device failed before tuning. But we need to tune it to meet spec.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Fagerburg pfagerburg@chromium.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 05:34:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org Comment-In-Reply-To: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

25 Apr 25 Apr

9 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Sat, 25 Apr 2020 15:00:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:27 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40688 )

Change subject: mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz ......................................................................

mb/google/hatch/var/jinlon: Tune i2c frequency under 400 KHz

Tuning i2c frequency for jinlon: I2C0: 392.7 KHz I2C1: 390 KHz I2C3: unused I2C4: 388.8 KHz

BUG=b:154900217 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage, and measured with scope

Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40688 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 7cf434d..5462670 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -46,15 +46,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 30, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, + .rise_time_ns = 20, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 40, + .fall_time_ns = 60, }, }"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b186193f34027d03dd349cf1e29bb266b167383 Gerrit-Change-Number: 40688 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Philip Chen philipchen@google.com Gerrit-CC: Shelley Chen shchen@google.com Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: merged

1843

days inactive

1844

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Chen Wisley (Code Review)
Paul Fagerburg (Code Review)
Tim Wawrzynczak (Code Review)
Wisley Chen (Code Review)