Change in ...coreboot[master]: src/mainboard/google: Add Helios support

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32918

Change subject: src/mainboard/google: Add Helios support
......................................................................

src/mainboard/google: Add Helios support

Add Helios as a variant of Hatch.

BUG=b:133182138
BRANCH=None
TEST=util/abuild/abuild -p none -t google/hatch -x -a
  attempts to build a Helios target.

Change-Id: I64ba06932eb0ee32405f7b14a94971a64c8fce71
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32918/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 09f79212..fdbc47d 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -65,6 +65,7 @@
    default "HATCH TEST 1823" if BOARD_GOOGLE_HATCH
    default "HATCH_WHL TEST 2374" if BOARD_GOOGLE_HATCH_WHL
    default "KOHAKU TEST 1953" if BOARD_GOOGLE_KOHAKU
+	default "HELIOS TEST 0878" if BOARD_GOOGLE_HELIOS

config MAINBOARD_DIR
    string
@@ -79,6 +80,7 @@
    default "Hatch" if BOARD_GOOGLE_HATCH
    default "Hatch_whl" if BOARD_GOOGLE_HATCH_WHL
    default "Kohaku" if BOARD_GOOGLE_KOHAKU
+	default "Helios" if BOARD_GOOGLE_HELIOS

config MAINBOARD_VENDOR
    string
@@ -101,6 +103,7 @@
    default "hatch" if BOARD_GOOGLE_HATCH
    default "hatch_whl" if BOARD_GOOGLE_HATCH_WHL
    default "kohaku" if BOARD_GOOGLE_KOHAKU
+	default "helios" if BOARD_GOOGLE_HELIOS

config VBOOT
    select HAS_RECOVERY_MRC_CACHE
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index eb8e612..8ebff58 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -17,3 +17,9 @@
    select BOARD_GOOGLE_BASEBOARD_HATCH
    select BOARD_ROMSIZE_KB_16384
    select SOC_INTEL_COMETLAKE
+
+config BOARD_GOOGLE_HELIOS
+	bool "->  Helios"
+	select BOARD_GOOGLE_BASEBOARD_HATCH
+	select BOARD_ROMSIZE_KB_16384
+	select SOC_INTEL_COMETLAKE

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 2:

This change is ready for review.

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 2: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32918

to look at the new patch set (#3).

Change subject: src/mainboard/google: Add Helios support
......................................................................

src/mainboard/google: Add Helios support

Add Helios as a variant of Hatch.

BUG=b:133182138
BRANCH=None
TEST=util/abuild/abuild -p none -t google/hatch -x -a
  attempts to build a Helios target.

Change-Id: I64ba06932eb0ee32405f7b14a94971a64c8fce71
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 12 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32918/3

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 3: Code-Review+1

The lint verifier is complaining about extra newlines at the end of Kconfig.name, but it's not showing up in the diff view for me. Please check it out.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32918/3/src/mainboard/google/hatch/Kconfig.n... 
File src/mainboard/google/hatch/Kconfig.name:

https://review.coreboot.org/#/c/32918/3/src/mainboard/google/hatch/Kconfig.n... 
PS3, Line 32: 
Just remove this line.

[Tim Wawrzynczak (Code Review)]

Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32918

to look at the new patch set (#4).

Change subject: src/mainboard/google: Add Helios support
......................................................................

src/mainboard/google: Add Helios support

Add Helios as a variant of Hatch.

BUG=b:133182138
BRANCH=None
TEST=util/abuild/abuild -p none -t google/hatch -x -a
  attempts to build a Helios target.

Change-Id: I64ba06932eb0ee32405f7b14a94971a64c8fce71
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 12 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32918/4

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 4: Code-Review+2

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: src/mainboard/google: Add Helios support
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32918/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32918/4//COMMIT_MSG@7 
PS4, Line 7: src/mainboard/google
mainboard/google/hatch

Change in ...coreboot[master]: mainboard/google/hatch: Add Helios support

[Tim Wawrzynczak (Code Review)]

Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32918

to look at the new patch set (#5).

Change subject: mainboard/google/hatch: Add Helios support
......................................................................

mainboard/google/hatch: Add Helios support

Add Helios as a variant of Hatch.

BUG=b:133182138
BRANCH=None
TEST=util/abuild/abuild -p none -t google/hatch -x -a
  attempts to build a Helios target.

Change-Id: I64ba06932eb0ee32405f7b14a94971a64c8fce71
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 12 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32918/5

Change in ...coreboot[master]: mainboard/google/hatch: Add Helios support

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: mainboard/google/hatch: Add Helios support
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32918/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32918/4//COMMIT_MSG@7 
PS4, Line 7: src/mainboard/google
> mainboard/google/hatch

Done

Change in ...coreboot[master]: mainboard/google/hatch: Add Helios support

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: mainboard/google/hatch: Add Helios support
......................................................................

Patch Set 5: Code-Review+2

Change in ...coreboot[master]: mainboard/google/hatch: Add Helios support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: mainboard/google/hatch: Add Helios support
......................................................................

Patch Set 5: Code-Review+2

Change in ...coreboot[master]: mainboard/google/hatch: Add Helios support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32918 )

Change subject: mainboard/google/hatch: Add Helios support
......................................................................

mainboard/google/hatch: Add Helios support

Add Helios as a variant of Hatch.

BUG=b:133182138
BRANCH=None
TEST=util/abuild/abuild -p none -t google/hatch -x -a
  attempts to build a Helios target.

Change-Id: I64ba06932eb0ee32405f7b14a94971a64c8fce71
Signed-off-by: Tim Wawrzynczak 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32918
Reviewed-by: Shelley Chen 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Paul Fagerburg 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 12 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Shelley Chen: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index e3927c0..8045129 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -64,8 +64,9 @@
    depends on CHROMEOS
    default "HATCH TEST 1823" if BOARD_GOOGLE_HATCH
    default "HATCH_WHL TEST 2374" if BOARD_GOOGLE_HATCH_WHL
-	default "KOHAKU TEST 1953" if BOARD_GOOGLE_KOHAKU
+	default "HELIOS TEST 0878" if BOARD_GOOGLE_HELIOS
    default "KINDRED TEST 2636" if BOARD_GOOGLE_KINDRED
+	default "KOHAKU TEST 1953" if BOARD_GOOGLE_KOHAKU

config MAINBOARD_DIR
    string
@@ -79,8 +80,9 @@
    string
    default "Hatch" if BOARD_GOOGLE_HATCH
    default "Hatch_whl" if BOARD_GOOGLE_HATCH_WHL
-	default "Kohaku" if BOARD_GOOGLE_KOHAKU
+	default "Helios" if BOARD_GOOGLE_HELIOS
    default "Kindred" if BOARD_GOOGLE_KINDRED
+	default "Kohaku" if BOARD_GOOGLE_KOHAKU

config MAINBOARD_VENDOR
    string
@@ -102,8 +104,9 @@
    string
    default "hatch" if BOARD_GOOGLE_HATCH
    default "hatch_whl" if BOARD_GOOGLE_HATCH_WHL
-	default "kohaku" if BOARD_GOOGLE_KOHAKU
+	default "helios" if BOARD_GOOGLE_HELIOS
    default "kindred" if BOARD_GOOGLE_KINDRED
+	default "kohaku" if BOARD_GOOGLE_KOHAKU

config VBOOT
    select HAS_RECOVERY_MRC_CACHE
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index 43fd4be..9a25725 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -23,3 +23,9 @@
    select BOARD_GOOGLE_BASEBOARD_HATCH
    select BOARD_ROMSIZE_KB_16384
    select SOC_INTEL_COMETLAKE
+
+config BOARD_GOOGLE_HELIOS
+	bool "->  Helios"
+	select BOARD_GOOGLE_BASEBOARD_HATCH
+	select BOARD_ROMSIZE_KB_16384
+	select SOC_INTEL_COMETLAKE