Attention is currently required from: Jianeng Ceng, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/d8291e71_4b3ac33a :
PS9, Line 11: #define RT5645_DP_INT(key, val) \
no need macro if just use ones
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment