Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19469 )
Change subject: soc/intel/skylake: Use common I2C code from intelblocks
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/19469/6/src/soc/intel/skylake/bootblock/boot...
File src/soc/intel/skylake/bootblock/bootblock.c:
PS6, Line 56: CONFIG_SKYLAKE_I2C_CTRL_MAX
Why have this a Kconfig? Just make it a #define somewhere and be done. I do
Done
--
To view, visit
https://review.coreboot.org/19469
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae7d13303090c72380534618741858502cc9ee33
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes