Change in coreboot[master]: src/console: Bring back support for printf'ing 64bit ints

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37113 )

Change subject: src/console: Bring back support for printf'ing 64bit ints
......................................................................

src/console: Bring back support for printf'ing 64bit ints

commit f96d9051c2 (Remove MIPS Architecture) accidentally enabled
a MIPS special case to not support 64bit integers in printf for
all platforms.

This removes that MIPS-only special case entirely.

Change-Id: I5245bb32b45f9bd37bd012a7b15a64fba24a4cb7
Signed-off-by: Patrick Georgi 
---
M src/console/vtxprintf.c
1 file changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/37113/1

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c
index b9e4369..104f4ea 100644
--- a/src/console/vtxprintf.c
+++ b/src/console/vtxprintf.c
@@ -36,20 +36,8 @@
    const char *digits = "0123456789abcdef";
    int i;
    int count = 0;
-#ifdef SUPPORT_64BIT_INTS
    unsigned long long num = inum;
    long long snum = num;
-#else
-	unsigned long num = (unsigned long)inum;
-	long snum = (long)num;
-
-	if (num != inum) {
-		/* Alert user to an incorrect result by printing #^!. */
-		call_tx('#');
-		call_tx('^');
-		call_tx('!');
-	}
-#endif

if (type & LARGE)
    	digits = "0123456789ABCDEF";

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37113 )

Change subject: src/console: Bring back support for printf'ing 64bit ints
......................................................................

Patch Set 1: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37113 )

Change subject: src/console: Bring back support for printf'ing 64bit ints
......................................................................

Patch Set 1: Code-Review+2

Whoops, sorry about that.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37113 )

Change subject: src/console: Bring back support for printf'ing 64bit ints
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37113 )

Change subject: src/console: Bring back support for printf'ing 64bit ints
......................................................................

src/console: Bring back support for printf'ing 64bit ints

commit f96d9051c2 (Remove MIPS Architecture) accidentally enabled
a MIPS special case to not support 64bit integers in printf for
all platforms.

This removes that MIPS-only special case entirely.

Change-Id: I5245bb32b45f9bd37bd012a7b15a64fba24a4cb7
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37113
Tested-by: build bot (Jenkins) 
Reviewed-by: Jacob Garber 
Reviewed-by: Julius Werner 
Reviewed-by: Angel Pons 
---
M src/console/vtxprintf.c
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Jacob Garber: Looks good to me, approved

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c
index b9e4369..104f4ea 100644
--- a/src/console/vtxprintf.c
+++ b/src/console/vtxprintf.c
@@ -36,20 +36,8 @@
    const char *digits = "0123456789abcdef";
    int i;
    int count = 0;
-#ifdef SUPPORT_64BIT_INTS
    unsigned long long num = inum;
    long long snum = num;
-#else
-	unsigned long num = (unsigned long)inum;
-	long snum = (long)num;
-
-	if (num != inum) {
-		/* Alert user to an incorrect result by printing #^!. */
-		call_tx('#');
-		call_tx('^');
-		call_tx('!');
-	}
-#endif

if (type & LARGE)
    	digits = "0123456789ABCDEF";