Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40493 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines ......................................................................
mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines
This is needed for getting a pair of Crucial BLT8G3D1869DT1TX0 sticks to work at 1600 MHz CL9 speeds, together with the "AMD_XMP" changes (1866 MHz is impossible on f16kb without northbridge overclocking).
Will be tested again as soon as possible.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Iff0cc3584bc2a3c20ba3f7ce455015b946dd3490 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/40493/1
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 71fedaa..51f46de 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -61,7 +61,7 @@ #define BLDOPT_REMOVE_ECC_SUPPORT TRUE //#define BLDOPT_REMOVE_BANK_INTERLEAVE TRUE //#define BLDOPT_REMOVE_DCT_INTERLEAVE TRUE -//#define BLDOPT_REMOVE_NODE_INTERLEAVE TRUE +#define BLDOPT_REMOVE_NODE_INTERLEAVE TRUE #define BLDOPT_REMOVE_PARALLEL_TRAINING TRUE #define BLDOPT_REMOVE_ONLINE_SPARE_SUPPORT TRUE //#define BLDOPT_REMOVE_MEM_RESTORE_SUPPORT TRUE @@ -108,15 +108,15 @@ #define BLDCFG_MEMORY_RDIMM_CAPABLE TRUE #define BLDCFG_MEMORY_UDIMM_CAPABLE TRUE #define BLDCFG_MEMORY_SODIMM_CAPABLE FALSE -#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING FALSE +#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING TRUE #define BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING FALSE -#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING FALSE +#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING TRUE #define BLDCFG_MEMORY_POWER_DOWN TRUE #define BLDCFG_POWER_DOWN_MODE POWER_DOWN_BY_CHIP_SELECT #define BLDCFG_ONLINE_SPARE FALSE #define BLDCFG_BANK_SWIZZLE TRUE #define BLDCFG_TIMING_MODE_SELECT TIMING_MODE_AUTO -#define BLDCFG_MEMORY_CLOCK_SELECT DDR1333_FREQUENCY +#define BLDCFG_MEMORY_CLOCK_SELECT DDR1600_FREQUENCY #define BLDCFG_DQS_TRAINING_CONTROL TRUE #define BLDCFG_IGNORE_SPD_CHECKSUM TRUE #define BLDCFG_USE_BURST_MODE FALSE
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40493
to look at the new patch set (#2).
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines ......................................................................
mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines
This is needed for getting a pair of Crucial BLT8G3D1869DT1TX0 sticks to work at 1600 MHz CL8 speeds, together with the "AMD_XMP" changes (1866 MHz CL9 is impossible on f16kb without northbridge overclocking).
Will be tested again as soon as possible.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Iff0cc3584bc2a3c20ba3f7ce455015b946dd3490 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/40493/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40493 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines ......................................................................
Patch Set 2:
Summary diff from this relation chain - https://pastebin.com/nEzz3MuX . SHA256 = 358ba15df788a3d53b0ecbc8c83bcd1a7dec4f8113b1f5bb0d047cf4f43594d8
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40493 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40493/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40493/2//COMMIT_MSG@7 PS2, Line 7: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines Please be more specific. Maybe:
mb/asus/am1i-a: Configure AGESA to support 1600 MHz RAM speeds
https://review.coreboot.org/c/coreboot/+/40493/2//COMMIT_MSG@9 PS2, Line 9: This is needed for getting a pair of Crucial BLT8G3D1869DT1TX0 sticks : to work at 1600 MHz CL8 speeds, What are they currently detected at? What does the vendor firmware support?
https://review.coreboot.org/c/coreboot/+/40493/2//COMMIT_MSG@12 PS2, Line 12: Please elaborate why the interleaving options need to be changed.
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40493 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM-related defines ......................................................................
Abandoned
Superseded by CB:40532 and CB:40533 with these comments addressed.
-
Mike Banon (Code Review) -
Paul Menzel (Code Review)