Attention is currently required from: Kangheui Won, Reka Norman.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67670 )
Change subject: drivers/mrc_cache: Compare hashes instead of full data ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67670/comment/7f76176f_ad7508d3 PS2, Line 18: 14 ms on uncached data on nissa The fact that this is 14ms both here and below is pretty conspicuous. I bet that the 14ms are just the time it takes to load this from RAM byte-by-byte, whereas 4ms are the time it takes loading in 32-bit chunks. So I would expect the speed advantage to disappear here with cache turned on. But xxhash should still be fast enough to make the difference insignificant.
(Also made me notice that we don't have an optimized memcmp() for x86, that's maybe worth fixing if we end up memcmp'ing uncached data a lot.)
-
Julius Werner (Code Review)