Attention is currently required from: Jonathan Zhang, Johnny Lin, Ed Sharma, Martin Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/56b52a33_a3201bf0 PS2, Line 7: commonlib/fsp_relocate: Fix Coverity Issues For the summary/title it’s not important what tool found an issue. Please look through `git log --grep overity` how to be more specific.
https://review.coreboot.org/c/coreboot/+/68637/comment/583dc665_cc021366 PS2, Line 9: Recently committed change 1df1cf9 resulted in some Coverity : reported issues. This change attempts to fix the static : analysis issues reported. The issues were reported as : comments in https://review.coreboot.org/c/coreboot/+/66819 : I have looked at all Coverity fixes before my change using : git log --oneline | grep -i coverity and then detailed : git diffs for all coverity changes. However none of them : had the same coverity errors reported as were reported : for my changes. I do not have the manner to run coverity : on my own to test my changes against coverity tests. : : TESTED= : This code is tested with Intel CooperLake-SP FSP version : 2.2.0.33A for DeltaLake boot Please reflow for 72 characters per line.
Patchset:
PS2: Welcome to coreboot. Thanks a lot for your contribution.