Change in coreboot[master]: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ......................................................................
Patch Set 36:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48750/34/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/34/src/mainboard/clevo/cml-u/... PS34, Line 69: GMA_STATIC_DISPLAYS
Is this actually what you want? The macro was introduced to reduce the […]
adapted, see latest ps
https://review.coreboot.org/c/coreboot/+/48750/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/36/src/mainboard/clevo/cml-u/... PS36, Line 69: 0x400 @Nico is that right?
type (11:8) = 0x400 (eDP = 4) port (7:4) = 0x00 (Port A = 0) zero-based index (3:0) = 0 (first display = 0)
-
Michael Niewöhner (Code Review)