Change in ...coreboot[master]: google/mistral: Enable additional GBB flags in vboot.

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

SANTHOSH JANARDHANA HASSAN (Code Review)

31 Jan 2019 31 Jan '19

7:28 a.m.

SANTHOSH JANARDHANA HASSAN has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31171

Change subject: google/mistral: Enable additional GBB flags in vboot. ......................................................................

google/mistral: Enable additional GBB flags in vboot.

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: If1e7effb2d74b861f196ce861a3c8779ce89b3b2

Signed-off-by: Santhosh Hassan sahassan@google.com Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/1

diff --git a/src/mainboard/google/mistral/Kconfig b/src/mainboard/google/mistral/Kconfig index c369472..5e97bb6 100644 --- a/src/mainboard/google/mistral/Kconfig +++ b/src/mainboard/google/mistral/Kconfig @@ -20,7 +20,9 @@ config VBOOT select VBOOT_VBNV_FLASH select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DEV_SCREEN_SHORT_DELAY select GBB_FLAG_FORCE_DEV_SWITCH_ON + select GBB_FLAG_FORCE_MANUAL_RECOVERY

config MAINBOARD_DIR string

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

SANTHOSH JANARDHANA HASSAN (Code Review)

31 Jan 31 Jan

7:32 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31171

to look at the new patch set (#2).

Change subject: google/mistral: Enable additional GBB flags in vboot. ......................................................................

google/mistral: Enable additional GBB flags in vboot.

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/2

SANTHOSH JANARDHANA HASSAN (Code Review)

8:06 a.m.

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31171

to look at the new patch set (#3).

Change subject: google/mistral: Enable additional GBB flags in vboot. ......................................................................

google/mistral: Enable additional GBB flags in vboot.

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 3 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

11:53 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: google/mistral: Enable additional GBB flags in vboot. ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/31171/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31171/3//COMMIT_MSG@7 PS3, Line 7: google/mistral: Enable additional GBB flags in vboot. Please remove the dot/period at the end of the commit message summary.

https://review.coreboot.org/#/c/31171/3//COMMIT_MSG@11 PS3, Line 11: Please give a motivation for the change, and how you tested this.

Paul Menzel (Code Review)

18 Feb 18 Feb

1:41 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: google/mistral: Enable additional GBB flags in vboot. ......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/31171/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31171/7//COMMIT_MSG@7 PS7, Line 7: google/mistral: Enable additional GBB flags in vboot. Please remove the dot at the end.

https://review.coreboot.org/#/c/31171/7//COMMIT_MSG@11 PS7, Line 11: Please document in the commit message, why these are needed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 7 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-Comment-Date: Mon, 18 Feb 2019 12:41:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

SANTHOSH JANARDHANA HASSAN (Code Review)

9 Mar 9 Mar

6:15 a.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in ...

Hello build bot (Jenkins), nsekar@codeaurora.org, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31171

to look at the new patch set (#10).

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot. ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot.

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 10 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

27 Mar 27 Mar

9:32 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in ...

Patrick Georgi has uploaded a new patch set (#13) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 13 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

10 Apr 10 Apr

8:47 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in ...

Patrick Georgi has uploaded a new patch set (#15) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable additional GBB flags in vboot

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 15 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

12 Aug 12 Aug

6:03 p.m.

New subject: Change in coreboot[master]: google/mistral: Enable additional GBB flags in vboot

Patrick Georgi has uploaded a new patch set (#29) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: google/mistral: Enable additional GBB flags in vboot ......................................................................

google/mistral: Enable additional GBB flags in vboot

Enable GBB_FLAG_FORCE_MANUAL_RECOVERY and GBB_FLAG_DEV_SCREEN_SHORT_DELAY as additional default flags.

Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/31171/29

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 29 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11 Mar 11 Mar

4:22 p.m.

New subject: Change in coreboot[master]: google/mistral: Enable additional GBB flags in vboot

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31171 )

Change subject: google/mistral: Enable additional GBB flags in vboot ......................................................................

Abandoned

won't be finished here

-- To view, visit https://review.coreboot.org/c/coreboot/+/31171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0a00c6a7bfa5090461c2c9da0bc6ee73118ca74 Gerrit-Change-Number: 31171 Gerrit-PatchSet: 29 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yuji Sasaki sasakiy@google.com Gerrit-MessageType: abandon

1710

days inactive

2115

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Patrick Georgi (Code Review)
Paul Menzel (Code Review)
SANTHOSH JANARDHANA HASSAN (Code Review)