Attention is currently required from: Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52937 )
Change subject: tests: Enable config override for tests
......................................................................
Patch Set 2:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52937/comment/7566b51c_ea63cfd8
PS2, Line 89: $(TEST_KCONFIG_AUTOHEADER)
The rule doesn't seem to have any inputs except the variables, so I don't think that dependency is n […]
It does not use file under path from this variable directly, but logically it does. Please correct me if I am wrong, but $(TEST_KCONFIG_AUTOHEADER) has to be executed to generate config and I think this is best place for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1aeb78362c2609fbefbfd91c0f58ec19ed258ee1
Gerrit-Change-Number: 52937
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Tue, 11 May 2021 16:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment