Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34526 )
Change subject: util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS ......................................................................
util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS
The abuild script will `cd` into the build directory. FAILED_BOARDS defaults to a relative path, so it ends up trying to echo into a directory that doesn't exist.
If we set the realpath to the file then we can correctly update the failed/passed boards file.
BUG=none TEST=make what-jenkins-does and verified there was a failed_boards and passed_boards in coreboot-builds.
Change-Id: Ib3af003b090668380a9425583a9f4367023820a6 Signed-off-by: Raul E Rangel rrangel@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34526 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild 1 file changed, 7 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/util/abuild/abuild b/util/abuild/abuild index b816d3f..03be0d4 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -746,13 +746,18 @@ exit 1 fi
+if ! mkdir -p "$TARGET"; then + echo "Unable to create build directory" + exit 1 +fi + customizing=$(echo "$customizing" | cut -c3-) if [ "$customizing" = "" ]; then customizing="default configuration" fi
-FAILED_BOARDS="${TARGET}/failed_boards" -PASSED_BOARDS="${TARGET}/passing_boards" +FAILED_BOARDS="$(realpath ${TARGET}/failed_boards)" +PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"
if [ "$recursive" = "false" ]; then rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"