Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Enable melf touchscreen
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29830 )
Change subject: mb/google/sarien/variants/sarien: Enable melf touchscreen ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants... PS2, Line 124: GPP_B13
Do we need to change the schematic? or remove the reset GPIO setting? […]
Does it work to just leave out the reset_gpio settings? It looks like this should be possible since the "has_power_resource" option is used.
This assumes the touchscreen hardware doesn't have any specific sequencing requirements, which may be the case since it a separate reset pin is not exposed.
-
Duncan Laurie (Code Review)