Change in ...coreboot[master]: util/genbuild_h: Prefer iasl from .xcompile over a hard code

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32300

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

util/genbuild_h: Prefer iasl from .xcompile over a hard code

build.h provides iasl's version but right now assumes that it's kept in
util/crossgcc/xgcc/bin. Often true, but not always, so use the one found
in .xcompile to query the version as that's the version that is used in
coreboot builds.

Change-Id: Iaeedc22e0e14fa96b4f2a68127f405c7f0c9d5cc
Signed-off-by: Patrick Georgi 
---
M util/genbuild_h/genbuild_h.sh
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/32300/1

diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh
index bafdbc9..c264b74 100755
--- a/util/genbuild_h/genbuild_h.sh
+++ b/util/genbuild_h/genbuild_h.sh
@@ -52,6 +52,9 @@
 esac
 }

+IASL=util/crossgcc/xgcc/bin/iasl
+eval $(grep ^IASL:= .xcompile 2>/dev/null | sed s,:=,=,)
+
 #Print out the information that goes into build.h
 printf "/* build system definitions (autogenerated) */\n"
 printf "#ifndef __BUILD_H\n"
@@ -73,5 +76,5 @@
 printf "#define COREBOOT_DMI_DATE "$(our_date "$DATE" +%m/%d/%Y)"\n"
 printf "\n"
 printf "#define COREBOOT_COMPILE_TIME "$(our_date "$DATE" +%T)"\n"
-printf "#define ASL_VERSION 0x%d\n" `./util/crossgcc/xgcc/bin/iasl -v | grep version | sed 's/.*version //'`
+printf "#define ASL_VERSION 0x%d\n" `$IASL -v | grep version | sed 's/.*version //'`
 printf "#endif\n"

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32300 )

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh 
File util/genbuild_h/genbuild_h.sh:

https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh@79 
PS1, Line 79: printf "#define ASL_VERSION 0x%d\n" `$IASL -v | grep version | sed 's/.*version //'`
line over 80 characters

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32300 )

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

Patch Set 1: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32300 )

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

Patch Set 1: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32300 )

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh 
File util/genbuild_h/genbuild_h.sh:

https://review.coreboot.org/#/c/32300/1/util/genbuild_h/genbuild_h.sh@55 
PS1, Line 55: util/crossgcc/xgcc/bin
Nit: This could be changed to ${XGCCPATH} - I can look at that in a future commit.

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32300 )

Change subject: util/genbuild_h: Prefer iasl from .xcompile over a hard code
......................................................................

util/genbuild_h: Prefer iasl from .xcompile over a hard code

build.h provides iasl's version but right now assumes that it's kept in
util/crossgcc/xgcc/bin. Often true, but not always, so use the one found
in .xcompile to query the version as that's the version that is used in
coreboot builds.

Change-Id: Iaeedc22e0e14fa96b4f2a68127f405c7f0c9d5cc
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32300
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Martin Roth 
---
M util/genbuild_h/genbuild_h.sh
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved

diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh
index bafdbc9..c264b74 100755
--- a/util/genbuild_h/genbuild_h.sh
+++ b/util/genbuild_h/genbuild_h.sh
@@ -52,6 +52,9 @@
 esac
 }

+IASL=util/crossgcc/xgcc/bin/iasl
+eval $(grep ^IASL:= .xcompile 2>/dev/null | sed s,:=,=,)
+
 #Print out the information that goes into build.h
 printf "/* build system definitions (autogenerated) */\n"
 printf "#ifndef __BUILD_H\n"
@@ -73,5 +76,5 @@
 printf "#define COREBOOT_DMI_DATE "$(our_date "$DATE" +%m/%d/%Y)"\n"
 printf "\n"
 printf "#define COREBOOT_COMPILE_TIME "$(our_date "$DATE" +%T)"\n"
-printf "#define ASL_VERSION 0x%d\n" `./util/crossgcc/xgcc/bin/iasl -v | grep version | sed 's/.*version //'`
+printf "#define ASL_VERSION 0x%d\n" `$IASL -v | grep version | sed 's/.*version //'`
 printf "#endif\n"