Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39691 )
Change subject: soc/intel/cfl/vr_config: Add 8-core desktop CPU support ......................................................................
soc/intel/cfl/vr_config: Add 8-core desktop CPU support
Add 8-core desktop CPU support by adding the corresponding PCI IDs. Tested using "Intel Core(TM) i7-9700E".
Change-Id: I7a2e2e5fd1796deff81b032450242fb58031526d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/intel/cannonlake/vr_config.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/39691/1
diff --git a/src/soc/intel/cannonlake/vr_config.c b/src/soc/intel/cannonlake/vr_config.c index 21a8ae2..af3f1ec 100644 --- a/src/soc/intel/cannonlake/vr_config.c +++ b/src/soc/intel/cannonlake/vr_config.c @@ -202,6 +202,7 @@
return icc_max[domain]; } + case PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8: /* fallthrough */ case PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8: { uint16_t icc_max[NUM_VR_DOMAINS] = VR_CFG_ALL_DOMAINS_ICC(11.1, 193, 45, 45);
@@ -356,6 +357,7 @@ } return loadline[domain]; } + case PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8: /* fallthrough */ case PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8: { /* FIXME: Loadline isn't specified for S-series, using H-series default */ const uint16_t loadline[NUM_VR_DOMAINS] =
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39691 )
Change subject: soc/intel/cfl/vr_config: Add 8-core desktop CPU support ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39691 )
Change subject: soc/intel/cfl/vr_config: Add 8-core desktop CPU support ......................................................................
Patch Set 1: Code-Review+2
I wish I could test this on real hardware 😄
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39691 )
Change subject: soc/intel/cfl/vr_config: Add 8-core desktop CPU support ......................................................................
soc/intel/cfl/vr_config: Add 8-core desktop CPU support
Add 8-core desktop CPU support by adding the corresponding PCI IDs. Tested using "Intel Core(TM) i7-9700E".
Change-Id: I7a2e2e5fd1796deff81b032450242fb58031526d Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39691 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/cannonlake/vr_config.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/vr_config.c b/src/soc/intel/cannonlake/vr_config.c index 21a8ae2..af3f1ec 100644 --- a/src/soc/intel/cannonlake/vr_config.c +++ b/src/soc/intel/cannonlake/vr_config.c @@ -202,6 +202,7 @@
return icc_max[domain]; } + case PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8: /* fallthrough */ case PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8: { uint16_t icc_max[NUM_VR_DOMAINS] = VR_CFG_ALL_DOMAINS_ICC(11.1, 193, 45, 45);
@@ -356,6 +357,7 @@ } return loadline[domain]; } + case PCI_DEVICE_ID_INTEL_CFL_ID_S_DT_8: /* fallthrough */ case PCI_DEVICE_ID_INTEL_CFL_ID_S_S_8: { /* FIXME: Loadline isn't specified for S-series, using H-series default */ const uint16_t loadline[NUM_VR_DOMAINS] =
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)