Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Felix Singer, Jérémy Compostella, Lean Sheng Tan, Paul Menzel, Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )
Change subject: soc/intel/common/systemagent_server: Add server platform system agent
......................................................................
Patch Set 29:
(3 comments)
File src/soc/intel/common/block/systemagent-server/Kconfig:
https://review.coreboot.org/c/coreboot/+/83318/comment/99979e66_3a4b6a67?usp... :
PS26, Line 15: treated as 1s.
to clean up?
Done
https://review.coreboot.org/c/coreboot/+/83318/comment/15b71f23_b93595f1?usp... :
PS26, Line 26: default 0x100000
to clean up?
Done
File src/soc/intel/common/block/systemagent-server/common.c:
https://review.coreboot.org/c/coreboot/+/83318/comment/5fa90248_59b603b9?usp... :
PS29, Line 8: pci_moving_config32
I thought this existed in common code, any reason not to use it?
The common code is aimed to be used in ramstage, i.e., the first parameter is `struct device *`, but I need this function in romstage to probe the alignment of TSEG base.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If32c2a6524c9d55ce7f9c3dd203bcf85cab76c2c
Gerrit-Change-Number: 83318
Gerrit-PatchSet: 29
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 08 Nov 2024 00:35:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com