Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons, Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62827 )
Change subject: lib/cbfs: Compare addresses instead of arrays
......................................................................
Patch Set 1:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/62827/comment/7cc6a7a1_4bab50f0
PS1, Line 31: _preram_cbfs_cache
Where is this defined? […]
<symbols.h> actually, but that's part of the general memlayout stuff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69310b0bec166faa40f56a36c6d360065cf6b08a
Gerrit-Change-Number: 62827
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-Attention: Martin L Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 02 May 2022 23:00:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment