Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19849 )
Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................
Patch Set 7:
I've set READ_BUFFER_SIZE to 0x100, and made it return if there's any error reading or writing to the flash. I think it's safer that way. Limiting the I/O is nice, but ultimately, this feature is only for debugging purposes, so it doesn't need to be as optimized as that. It will do 10 reads instead of 1 before stopping, it's not the end of the world.
--
To view, visit
https://review.coreboot.org/19849
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: No