Hello SANTHOSH JANARDHANA HASSAN,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32272
to review the following change.
Change subject: mb/google/mistral: Ignore REC switch if TPM isn't ready ......................................................................
mb/google/mistral: Ignore REC switch if TPM isn't ready
The recovery button's state is cached in the TPM, but on first boot Cr50 isn't ready yet for this task, which leads to a reboot further down the road (to get TPM up).
To not confuse matters further, only act on the recovery button if the TPM is in fact able to cache the state.
BUG=b:129878075 BRANCH=none TEST=recovery button is only read on second boot
Change-Id: I1ad2c148be4cbdbb2afa05c46c483d89855e1959 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/mistral/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32272/1
diff --git a/src/mainboard/google/mistral/chromeos.c b/src/mainboard/google/mistral/chromeos.c index 9b69a4f..e0306b16 100644 --- a/src/mainboard/google/mistral/chromeos.c +++ b/src/mainboard/google/mistral/chromeos.c @@ -72,6 +72,9 @@ gpio_t rec_sw; static enum switch_state saved_state = not_probed;
+ if (is_tpm_detected() == 0) + return saved_state; + if (saved_state != not_probed) return saved_state;
Hello SANTHOSH JANARDHANA HASSAN, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32272
to look at the new patch set (#12).
Change subject: mb/google/mistral: Ignore REC switch if TPM isn't ready ......................................................................
mb/google/mistral: Ignore REC switch if TPM isn't ready
The recovery button's state is cached in the TPM, but on first boot Cr50 isn't ready yet for this task, which leads to a reboot further down the road (to get TPM up).
To not confuse matters further, only act on the recovery button if the TPM is in fact able to cache the state.
BUG=b:129878075 BRANCH=none TEST=recovery button is only read on second boot
Change-Id: I1ad2c148be4cbdbb2afa05c46c483d89855e1959 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/mistral/chromeos.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32272/12
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32272 )
Change subject: mb/google/mistral: Ignore REC switch if TPM isn't ready ......................................................................
Abandoned
won't be finished here
-
Patrick Georgi (Code Review)