New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Add LP5562 driver

8 May 2019

Hello Yuji Sasaki,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32693
to review the following change.
Change subject: TEMP: NOT FOR REVIEW: google/mistral: Add LP5562 driver
......................................................................
TEMP: NOT FOR REVIEW: google/mistral: Add LP5562 driver
Add LP5562 driver to mistral board file.
BUG=b:116352348
TEST=build coreboot and chromeos-bootimage, run on mistral.
Signed-off-by: Yuji Sasaki sasakiy@chromium.org
Change-Id: I0c26ac952671cb94a2e5681da6e2f2eafddedb48
---
M src/drivers/i2c/lp5562/led_lp5562_programs.c
M src/mainboard/google/mistral/Kconfig
M src/mainboard/google/mistral/board.h
M src/mainboard/google/mistral/bootblock.c
M src/mainboard/google/mistral/chromeos.c
5 files changed, 119 insertions(+), 94 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/32693/1

diff --git a/src/drivers/i2c/lp5562/led_lp5562_programs.c b/src/drivers/i2c/lp5562/led_lp5562_programs.c
index f322f6a..e837dfd 100644
--- a/src/drivers/i2c/lp5562/led_lp5562_programs.c
+++ b/src/drivers/i2c/lp5562/led_lp5562_programs.c
@@ -60,12 +60,12 @@
/* RGB set to 000000, resulting in all LEDs off. */
 static const uint8_t solid_00_text[] = {
-	0x40, 0x00, 0xc0, 0x00
+	0x40,    0, 0xc0, 0x00
 };
/* Rgb set to 128, resulting in a brightish white color. */
-static const uint8_t solid_80_text[] = {
-	0x40, 0x80, 0xc0, 0x00
+static const uint8_t solid_FF_text[] = {
+	0x40,  255, 0xc0, 0x00
 };
static const TiLp5562Program solid_000000_program = {
@@ -88,44 +88,94 @@
    }
 };
-static const TiLp5562Program solid_808080_program = {
+static const TiLp5562Program solid_FFFFFF_program = {
    {
    	{ /* Engine1:Blue */
-			solid_80_text,
-			sizeof(solid_80_text),
+			solid_FF_text,
+			sizeof(solid_FF_text),
    		0,
    	},
    	{ /* Engine2:Green */
-			solid_80_text,
-			sizeof(solid_80_text),
+			solid_FF_text,
+			sizeof(solid_FF_text),
    		0,
    	},
    	{ /* Engine3:Red */
-			solid_80_text,
-			sizeof(solid_80_text),
+			solid_FF_text,
+			sizeof(solid_FF_text),
    		0,
    	},
    }
 };
/*
+ * fdr_press1.src
+ *
+  1 00		.ENGINE1(B)
+  2 00 4000		set_pwm 0
+  3 01 C000		end
+  4 	
+  5 10		.ENGINE2(G)
+  6 10 40CC		set_pwm 204
+  7 11 C000		end
+  8 	
+  9 20		.ENGINE3(R)
+ 10 20 40FF		set_pwm 255
+ 11 21 C000		end
+*/
+
+static const uint8_t fdr_press1_b_text[] = {
+	0x40,     0,  0xc0,  0x00,
+};
+
+static const uint8_t fdr_press1_g_text[] = {
+	0x40,   204,  0xc0,  0x00
+};
+
+static const uint8_t fdr_press1_r_text[] = {
+	0x40,   255,  0xc0,  0x00
+};
+
+static const TiLp5562Program fdr_press1_program = {
+	{
+		{
+			fdr_press1_b_text,
+			sizeof(fdr_press1_b_text),
+			0,
+		},
+		{
+			fdr_press1_g_text,
+			sizeof(fdr_press1_g_text),
+			0,
+		},
+		{
+			fdr_press1_r_text,
+			sizeof(fdr_press1_r_text),
+			0,
+		},
+	}
+};
+
+/*
+ * blink_recovery1.src
+ *
   1 00          .ENGINE1(B)
   2 00 E200             trigger w3
-  3 01 409B             set_pwm 155
+  3 01 4000             set_pwm 0
   4 02 E200             trigger w3
   5 03 4000             set_pwm 0
   6 04 0000             gotostart
   7
   8 10          .ENGINE2(G)
   9 10 E200             trigger w3
- 10 11 4032             set_pwm 50
+ 10 11 40CC             set_pwm 204
  11 12 E200             trigger w3
  12 13 4000             set_pwm 0
  13 14 0000             gotostart
  14
  15 20          .ENGINE3(R)
  16 20 E006             trigger s21
- 17 21 4001             set_pwm 1
+ 17 21 40FF             set_pwm 255
  18 22 5300             wait 300
  19 23 E006             trigger s21
  20 24 4000             set_pwm 0
@@ -133,48 +183,13 @@
  22 26 0000             gotostart
 */
-static const uint8_t blink_wipeout1_b_text[] = {
-	0xe2,  0x00,  0x40,   155,  0xe2,  0x00,  0x40,     0,
-	0x00,  0x00,
-};
-
-static const uint8_t blink_wipeout1_g_text[] = {
-	0xe2,  0x00,  0x40,    50,  0xe2,  0x00,  0x40,     0,
-	0x00,  0x00,
-};
-
-static const uint8_t blink_wipeout1_r_text[] = {
-	0xe0,  0x06,  0x40,     1,  0x53,  0x00,  0xe0,  0x06,
-	0x40,     0,  0x53,  0x00,  0x00,  0x00
-};
-
-static const TiLp5562Program blink_wipeout1_program = {
-	{
-		{
-			blink_wipeout1_b_text,
-			sizeof(blink_wipeout1_b_text),
-			0,
-		},
-		{
-			blink_wipeout1_g_text,
-			sizeof(blink_wipeout1_g_text),
-			0,
-		},
-		{
-			blink_wipeout1_r_text,
-			sizeof(blink_wipeout1_r_text),
-			0,
-		},
-	}
-};
-
 static const uint8_t blink_recovery1_b_text[] = {
-	0xe2,  0x00,  0x40,    10,  0xe2,  0x00,  0x40,     0,
+	0xe2,  0x00,  0x40,     0,  0xe2,  0x00,  0x40,     0,
    0x00,  0x00,
 };
static const uint8_t blink_recovery1_g_text[] = {
-	0xe2,  0x00,  0x40,   100,  0xe2,  0x00,  0x40,     0,
+	0xe2,  0x00,  0x40,   204,  0xe2,  0x00,  0x40,     0,
    0x00,  0x00,
 };
@@ -187,73 +202,69 @@
    {
    	{
    		blink_recovery1_b_text,
-			sizeof(blink_wipeout1_b_text),
+			sizeof(blink_recovery1_b_text),
    		0,
    	},
    	{
    		blink_recovery1_g_text,
-			sizeof(blink_wipeout1_g_text),
+			sizeof(blink_recovery1_g_text),
    		0,
    	},
    	{
    		blink_recovery1_r_text,
-			sizeof(blink_wipeout1_r_text),
+			sizeof(blink_recovery1_r_text),
    		0,
    	},
    }
 };
/*
- * fade_in1.src
+ * preboot1.src
  *
   1 00          .ENGINE1(B)
   2 00 4000             set_pwm 0
   3 01 E200             trigger w3
-  4 02 1B4C             ramp 1000, 77 # ramp up to 155 for 2 seconds
-  5 03 1A4D             ramp 1000, 78
-  6 04 C000             end
-  7
-  8 10          .ENGINE2(G)
-  9 10 4000             set_pwm 0
- 10 11 E200             trigger w3
- 11 12 4318             ramp 1000, 25 # ramp up to 50 for 2 seconds
- 12 13 4318             ramp 1000, 25
- 13 14 C000             end
- 14
- 15 20          .ENGINE3(R)
- 16 20 E006             trigger s21
- 17 21 4001             set_pwm 1
- 18 22 E006             trigger s21
- 19 23 C000             end
+  4 02 0D4C             ramp 500, 77
+  5 03 C000             end
+  6
+  7 10          .ENGINE2(G)
+  8 10 4000             set_pwm 0
+  9 11 E200             trigger w3
+ 10 12 0D4C             ramp 500, 77
+ 11 13 C000             end
+ 12
+ 13 20          .ENGINE3(R)
+ 14 20 4000             set_pwm 0
+ 15 21 E006             trigger s21
+ 16 22 0D4C             ramp 500, 77
+ 17 23 C000             end
 */
-static const uint8_t fade_in1_b_text[] = {
-	0x40,     0,  0xe2,  0x00,  0x1b,  0x4c,  0x1a,  0x4d,
-	0xc0,  0x00
+static const uint8_t preboot1_b_text[] = {
+	0x40,  0x00,  0xe2,  0x00,  0x0d,  0x4c,  0xc0,  0x00
 };
-static const uint8_t fade_in1_g_text[] = {
-	0x40,     0,  0xe2,  0x00,  0x43,  0x18,  0x43,  0x18,
-	0xc0,  0x00
+static const uint8_t preboot1_g_text[] = {
+	0x40,  0x00,  0xe2,  0x00,  0x0d,  0x4c,  0xc0,  0x00
 };
-static const uint8_t fade_in1_r_text[] = {
-	0xe0,  0x06,  0x40,     1,  0xe0,  0x06,  0x00
+static const uint8_t preboot1_r_text[] = {
+	0x40,  0x00,  0xe0,  0x06,  0x0d,  0x4c,  0xc0,  0x00
 };
-static const TiLp5562Program fade_in1_program = {
+static const TiLp5562Program preboot1_program = {
    {
    	{
-			fade_in1_b_text,
-			sizeof(fade_in1_b_text),
+			preboot1_b_text,
+			sizeof(preboot1_b_text),
    		0,
    	},
    	{
-			fade_in1_g_text,
-			sizeof(fade_in1_g_text),
+			preboot1_g_text,
+			sizeof(preboot1_g_text),
    		0,
    	},
    	{
-			fade_in1_r_text,
-			sizeof(fade_in1_r_text),
+			preboot1_r_text,
+			sizeof(preboot1_r_text),
    		0,
    	},
    }
@@ -265,9 +276,9 @@
     * be changed soon.
     */
    {LED_ALL_OFF, {&solid_000000_program} },
-	{LED_RECOVERY_PUSHED, {&solid_808080_program} },
-	{LED_WIPEOUT_REQUEST, {&blink_wipeout1_program} },
+	{LED_RECOVERY_PUSHED, {&solid_FFFFFF_program} },
+	{LED_WIPEOUT_REQUEST, {&fdr_press1_program} },
    {LED_RECOVERY_REQUEST, {&blink_recovery1_program} },
-	{LED_NORMAL_BOOT, {&fade_in1_program} },
+	{LED_NORMAL_BOOT, {&preboot1_program} },
    {}, /* Empty record to mark the end of the table. */
 };
diff --git a/src/mainboard/google/mistral/Kconfig b/src/mainboard/google/mistral/Kconfig
index 87d2df8..4529abd 100644
--- a/src/mainboard/google/mistral/Kconfig
+++ b/src/mainboard/google/mistral/Kconfig
@@ -15,6 +15,7 @@
    select MAINBOARD_HAS_CHROMEOS
    select MAINBOARD_HAS_TPM2
    select MAINBOARD_HAS_SPI_TPM_CR50
+	select DRIVERS_I2C_LED_LP5562
config VBOOT
    select VBOOT_VBNV_FLASH
diff --git a/src/mainboard/google/mistral/board.h b/src/mainboard/google/mistral/board.h
index 51e4bf2..88db42c 100644
--- a/src/mainboard/google/mistral/board.h
+++ b/src/mainboard/google/mistral/board.h
@@ -23,6 +23,7 @@
 #define GPIO_H1_AP_INT	GPIO(53)
 #define GPIO_WP_STATE	GPIO(54)
 #define GPIO_REC_STATE	GPIO(77)
+#define GPIO_LED_ENABLE	GPIO(119)
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/mistral/bootblock.c b/src/mainboard/google/mistral/bootblock.c
index be7a71e..da9dda8 100644
--- a/src/mainboard/google/mistral/bootblock.c
+++ b/src/mainboard/google/mistral/bootblock.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2018, The Linux Foundation.  All rights reserved.
+ * Copyright (C) 2019, The Linux Foundation.  All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 and
@@ -15,9 +15,14 @@
#include <bootblock_common.h>
 #include <timestamp.h>
+#include <delay.h>
 #include "board.h"
void bootblock_mainboard_init(void)
 {
+	gpio_output(GPIO_LED_ENABLE, 0);
+	udelay(2);
+	gpio_set(GPIO_LED_ENABLE, 1);
+	mdelay(2);
    gpio_input_pullup(GPIO_H1_AP_INT);
 }
diff --git a/src/mainboard/google/mistral/chromeos.c b/src/mainboard/google/mistral/chromeos.c
index e0306b16..f220151 100644
--- a/src/mainboard/google/mistral/chromeos.c
+++ b/src/mainboard/google/mistral/chromeos.c
@@ -18,6 +18,8 @@
 #include <console/console.h>
 #include <security/tpm/tis.h>
 #include <timer.h>
+#include <drivers/i2c/lp5562/led_lp5562.h>
+#include <soc/blsp.h>
 #include "board.h"
void setup_chromeos_gpios(void)
@@ -65,6 +67,11 @@
    wipeout_req
 };
+static void display_pattern(int pattern)
+{
+	led_lp5562_display_pattern(BLSP_QUP_ID_1, pattern);
+}
+
 static enum switch_state get_rec_sw_state(void)
 {
    struct stopwatch sw;
@@ -83,11 +90,11 @@
if (!sampled_value) {
    	saved_state = no_req;
-		//display_pattern(WWR_NORMAL_BOOT);
+		display_pattern(LED_NORMAL_BOOT);
    	return saved_state;
    }
-	//display_pattern(WWR_RECOVERY_PUSHED);
+	display_pattern(LED_RECOVERY_PUSHED);
    printk(BIOS_INFO, "recovery button pressed\n");
stopwatch_init_msecs_expire(&sw, WIPEOUT_MODE_DELAY_MS);
@@ -99,7 +106,7 @@
    } while (!stopwatch_expired(&sw));
if (sampled_value) {
-		//display_pattern(WWR_WIPEOUT_REQUEST);
+		display_pattern(LED_WIPEOUT_REQUEST);
    	printk(BIOS_INFO, "wipeout requested, checking recovery\n");
    	stopwatch_init_msecs_expire(&sw, RECOVERY_MODE_EXTRA_DELAY_MS);
    	do {
@@ -110,14 +117,14 @@
if (sampled_value) {
    		saved_state = recovery_req;
-			//display_pattern(WWR_RECOVERY_REQUEST);
+			display_pattern(LED_RECOVERY_REQUEST);
    		printk(BIOS_INFO, "recovery requested\n");
    	} else {
    		saved_state = wipeout_req;
    	}
    } else {
    	saved_state = no_req;
-		//display_pattern(WWR_NORMAL_BOOT);
+		display_pattern(LED_NORMAL_BOOT);
    }
return saved_state;
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32693
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c26ac952671cb94a2e5681da6e2f2eafddedb48
Gerrit-Change-Number: 32693
Gerrit-PatchSet: 1
Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com
Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org
Gerrit-MessageType: newchange



    

Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Add LP5562 driver