Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77990?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: soc/amd/picasso: add eMMC MMIO device to devicetree ......................................................................
soc/amd/picasso: add eMMC MMIO device to devicetree
Add the eMMC MMIO device to the devicetree and make it use the common AMD eMMC driver. Since there is now a device for this in the devicetree, also use this device to determine if the FSP should be told if the eMMC controller is supposed to be disabled.
TEST=On Mandolin the eMMC controller both disappears in the Windows 10 device manager and in dmesg on Ubuntu 2022.04 LTS TEST=Morphius with NVMe SSD still works
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I5453b69df776d2ce1f3be11e37cd26c8c64f0cd5 --- M src/mainboard/amd/bilby/devicetree.cb M src/mainboard/amd/mandolin/variants/cereme/devicetree.cb M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb M src/mainboard/google/zork/variants/baseboard/dalboz/devicetree.cb M src/mainboard/google/zork/variants/baseboard/trembyle/devicetree.cb M src/mainboard/google/zork/variants/berknip/variant.c M src/mainboard/google/zork/variants/dalboz/variant.c M src/mainboard/google/zork/variants/ezkinil/variant.c M src/mainboard/google/zork/variants/morphius/variant.c M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi/mmio.asl M src/soc/amd/picasso/chip.h M src/soc/amd/picasso/chipset.cb M src/soc/amd/picasso/fsp_s_params.c 14 files changed, 20 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/77990/5