Attention is currently required from: Ivy Jian, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70226 )
Change subject: mb/google/rex: Use OV13B10 sensor for Proto 1 SKUs
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/70226/comment/a7e05edc_20cc4846
PS7, Line 276: b
nit: 13B10
most of the time, we ended up using smaller case in coreboot hence, use the same. I don't think there is anything right or wrong. I could see both example present in this file already.
marking it resolve @Eric, hoping you are good with keeping it as is
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic785b82db4368f40d91921f29c218cf417938541
Gerrit-Change-Number: 70226
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 04 Feb 2023 06:10:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment