Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ...

[Lucas Chen (Code Review)]

Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
......................................................................

mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.

Configure the correct eMMC present flag for Ezkinil new add sku_id.
0x5A020015  NVME present
0x5A020016  eMMC present
0x5A020017  eMMC present

BUG=b:159761042
TEST:none

Signed-off-by: Lucas Chen 
Change-Id: I1b89cc4568283d5dbebf0ab7ac578368d3a3637e
---
M src/mainboard/google/zork/variants/ezkinil/variant.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43753/1

diff --git a/src/mainboard/google/zork/variants/ezkinil/variant.c b/src/mainboard/google/zork/variants/ezkinil/variant.c
index d7cf5a8..afc24a7 100644
--- a/src/mainboard/google/zork/variants/ezkinil/variant.c
+++ b/src/mainboard/google/zork/variants/ezkinil/variant.c
@@ -17,7 +17,8 @@
        (board_sku == 0x5A020001) || (board_sku == 0x5A020002) ||
        (board_sku == 0x5A020005) || (board_sku == 0x5A020006) ||
        (board_sku == 0x5A020009) || (board_sku == 0x5A02000A) ||
-	    (board_sku == 0x5A02000D) || (board_sku == 0x5A02000E))
+	    (board_sku == 0x5A02000D) || (board_sku == 0x5A02000E) ||
+	    (board_sku == 0x5A020016) || (board_sku == 0x5A020017))
    	return 1;

return 0;

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
......................................................................

Patch Set 1: Code-Review+1

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
......................................................................

Patch Set 1:

a

[Rob Barnes (Code Review)]

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
......................................................................

Patch Set 1: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG@7 
PS1, Line 7: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
Please remove the dot/period at the end of the git commit message summary.
> Configure boot media for new SKUs

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG@9 
PS1, Line 9: add
added

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[David Wu (Code Review)]

David Wu has uploaded a new patch set (#2) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

mb/google/zork/var/ezkinil: Configure boot media for new SKUs

Configure the correct eMMC present flag for Ezkinil new added sku_id.
0x5A020015  NVME present
0x5A020016  eMMC present
0x5A020017  eMMC present

BUG=b:159761042
TEST:none

Signed-off-by: Lucas Chen 
Change-Id: I1b89cc4568283d5dbebf0ab7ac578368d3a3637e
---
M src/mainboard/google/zork/variants/ezkinil/variant.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43753/2

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[David Wu (Code Review)]

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG@7 
PS1, Line 7: mb/google/zork/var/ezkinil: Configure boot media for the new add sku ids.
> Please remove the dot/period at the end of the git commit message summary. […]

Done

https://review.coreboot.org/c/coreboot/+/43753/1//COMMIT_MSG@9 
PS1, Line 9: add
> added

Done

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/ezkinil/variant.c:

https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v... 
PS2, Line 22: 		return 1;
Lucas do all the devices have FW_CONFIG provisioned in CBI? If so, we should move to that.

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2: Code-Review-1

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2:

I can help plumb in fw_config so we can switch to it. I just want to confirm fw_config has been programmed for all devices (or at least EVT).

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2:
> Patch Set 2:
>
> I can help plumb in fw_config so we can switch to it. I just want to confirm fw_config has been programmed for all devices (or at least EVT).

Hi Arron, I check with our PM and EC engineer, seems the CBI data for EVT and new DVT build are not contain the fw_config field. I think the fw_config may not be programmed on all devices.

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > I can help plumb in fw_config so we can switch to it. I just want to confirm fw_config has been programmed for all devices (or at least EVT).
>
> Hi Arron, I check with our PM and EC engineer, seems the CBI data for EVT and new DVT build are not contain the fw_config field. I think the fw_config may not be programmed on all devices.

Sorry to correct the wrong information. We did written the fw_confg value during the factory machines build.

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/ezkinil/variant.c:

https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v... 
PS2, Line 22: 		return 1;
> Lucas do all the devices have FW_CONFIG provisioned in CBI? If so, we should move to that.

Bhanu is planning on implementing fw_config bindings in coreboot.

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Lucas Chen (Code Review)]

Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: mb/google/zork/var/ezkinil: Configure boot media for new SKUs

[Aaron Durbin (Code Review)]

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43753 )

Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................

mb/google/zork/var/ezkinil: Configure boot media for new SKUs

Configure the correct eMMC present flag for Ezkinil new added sku_id.
0x5A020015  NVME present
0x5A020016  eMMC present
0x5A020017  eMMC present

BUG=b:159761042
TEST:none

Signed-off-by: Lucas Chen 
Change-Id: I1b89cc4568283d5dbebf0ab7ac578368d3a3637e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43753
Reviewed-by: Aaron Durbin 
Reviewed-by: Rob Barnes 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/zork/variants/ezkinil/variant.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Lucas Chen: Looks good to me, but someone else must approve
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/zork/variants/ezkinil/variant.c b/src/mainboard/google/zork/variants/ezkinil/variant.c
index d7cf5a8..afc24a7 100644
--- a/src/mainboard/google/zork/variants/ezkinil/variant.c
+++ b/src/mainboard/google/zork/variants/ezkinil/variant.c
@@ -17,7 +17,8 @@
        (board_sku == 0x5A020001) || (board_sku == 0x5A020002) ||
        (board_sku == 0x5A020005) || (board_sku == 0x5A020006) ||
        (board_sku == 0x5A020009) || (board_sku == 0x5A02000A) ||
-	    (board_sku == 0x5A02000D) || (board_sku == 0x5A02000E))
+	    (board_sku == 0x5A02000D) || (board_sku == 0x5A02000E) ||
+	    (board_sku == 0x5A020016) || (board_sku == 0x5A020017))
    	return 1;

return 0;