[M] Change in coreboot[main]: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER

[Shuo Liu (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Tim Chu, Ziang Wang.

Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/81443?usp=email )

Change subject: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER
......................................................................

Patch Set 7:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81443/comment/81044333_57109c64?usp... :
PS6, Line 9: Add a new proximity type to represent the sub-NUMA
           : cluster (SNC).
           : 
           : This patch doesn't actually enable SNC. To fully enable
           : SNC, SoC codes need to override soc_get_cluster_count(),
           : soc_set_cpu_node_id() and memory_to_pd(), and call
           : soc_set_cpu_node_id() in its per-CPU init routine.
> Please re-flow for 72 characters per line.

Done

File src/soc/intel/xeon_sp/spr/chip.c:

https://review.coreboot.org/c/coreboot/+/81443/comment/58f6f7eb_c8e27bb3?usp... :
PS6, Line 178: 		if (pds.pds[i].pd_type != PD_TYPE_GENERIC_INITIATOR)
> Excuse my ignorance, but could these hunks be explained in the commit message?

Sure, added,

With SNC, there are 3 types of proximity domains,
PD_TYPE_PROCESSOR, PD_TYPE_GENERIC_INITIATOR and PD_TYPE_CLUSTER.
proximity domain type checks in Xeon-SP codes are updated to
correctly handle the adding of the new type.