HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39939 )
Change subject: mb/*/*/hda_verb.c: Improve code formatting ......................................................................
mb/*/*/hda_verb.c: Improve code formatting
Change-Id: I294ea867678ad77e454873ecf4948bf2d12c9f80 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39939/1
diff --git a/src/mainboard/asus/p5gc-mx/hda_verb.c b/src/mainboard/asus/p5gc-mx/hda_verb.c index 7edd171..c6f8673 100644 --- a/src/mainboard/asus/p5gc-mx/hda_verb.c +++ b/src/mainboard/asus/p5gc-mx/hda_verb.c @@ -16,9 +16,9 @@
const u32 cim_verb_data[] = { /* coreboot specific header */ - 0x10ec0883, /* Vendor ID */ - 0x104382c7, /* Subsystem ID */ - 0x0000000c, /* Number of entries */ + 0x10ec0883, /* Vendor ID */ + 0x104382c7, /* Subsystem ID */ + 0x0000000c, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010), diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c index 55cff05..c5d846b 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c @@ -15,9 +15,9 @@
const u32 cim_verb_data[] = { /* coreboot specific header */ - 0x10ec0662, /* Vendor ID */ - 0x1458a002, /* Subsystem ID */ - 0x00000009, /* Number of entries */ + 0x10ec0662, /* Vendor ID */ + 0x1458a002, /* Subsystem ID */ + 0x00000009, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010),
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39939 )
Change subject: mb/*/*/hda_verb.c: Improve code formatting ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39939 )
Change subject: mb/*/*/hda_verb.c: Improve code formatting ......................................................................
mb/*/*/hda_verb.c: Improve code formatting
Change-Id: I294ea867678ad77e454873ecf4948bf2d12c9f80 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39939 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p5gc-mx/hda_verb.c M src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p5gc-mx/hda_verb.c b/src/mainboard/asus/p5gc-mx/hda_verb.c index 897b1d5..cd69122 100644 --- a/src/mainboard/asus/p5gc-mx/hda_verb.c +++ b/src/mainboard/asus/p5gc-mx/hda_verb.c @@ -5,9 +5,9 @@
const u32 cim_verb_data[] = { /* coreboot specific header */ - 0x10ec0883, /* Vendor ID */ - 0x104382c7, /* Subsystem ID */ - 0x0000000c, /* Number of entries */ + 0x10ec0883, /* Vendor ID */ + 0x104382c7, /* Subsystem ID */ + 0x0000000c, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010), diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c index d6fefcd..21f8ad8 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/hda_verb.c @@ -5,9 +5,9 @@
const u32 cim_verb_data[] = { /* coreboot specific header */ - 0x10ec0662, /* Vendor ID */ - 0x1458a002, /* Subsystem ID */ - 0x00000009, /* Number of entries */ + 0x10ec0662, /* Vendor ID */ + 0x1458a002, /* Subsystem ID */ + 0x00000009, /* Number of entries */
/* Pin Widget Verb Table */ AZALIA_PIN_CFG(0, 0x14, 0x01014010),
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39939 )
Change subject: mb/*/*/hda_verb.c: Improve code formatting ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2225 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2224 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2223
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)