Attention is currently required from: Ravi kumar, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 9:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/e1c85258_e74d993b PS9, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/6b98a447_9cd929c0 PS9, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/29e73758_5dc82cf7 PS9, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/59338017_dfaaca90 PS9, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/93bba0d3_6df4a703 PS9, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/4d155c76_962c527a PS9, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/1deda090_c4b99cc4 PS9, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/1aa4d9ec_3917d5ae PS9, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/98c5d1fc_9629d28f PS9, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/92c20d0c_2bb38829 PS9, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119431): https://review.coreboot.org/c/coreboot/+/52371/comment/55efecc6_70795778 PS9, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)
-
build bot (Jenkins) (Code Review)