Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54754 )
Change subject: cpu/x86/mp_init.c: Fix building with no smihandler ......................................................................
cpu/x86/mp_init.c: Fix building with no smihandler
The build fails because smm_stub_size() tries to find a symbol that won't be present.
Change-Id: I73fee3cf26c0e37cca03299c6730f7b4f1ef6685 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/54754 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/cpu/x86/mp_init.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 46cb585..709e7a2 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -1072,6 +1072,9 @@ if (ops->get_cpu_count != NULL) state->cpu_count = ops->get_cpu_count();
+ if (!is_smm_enabled()) + return; + if (ops->get_smm_info != NULL) ops->get_smm_info(&state->perm_smbase, &state->perm_smsize, &state->smm_real_save_state_size);
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.