[XS] Change in coreboot[main]: src/arch/x86/c_start: Delete duplicated code masking stack pointer - coreboot-gerrit

7 Apr 2025


      Attention is currently required from: Jérémy Compostella, Shuo Liu.
NyeonWoo Kim has posted comments on this change by NyeonWoo Kim. ( https://review.coreboot.org/c/coreboot/+/87181?usp=email )
Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87181/comment/7014f85f_b58b0eb1?usp... :
PS1, Line 32: 	...
...
Are you meaning ln77/94?
yes i am.
it seems that line 77/94 is duplicated by line 106/108 in c_start.S.
so i would like to remove duplication.
if i'm wrong, plz let me know. 
i'll cancel it!.
:)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/87181?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6
Gerrit-Change-Number: 87181
Gerrit-PatchSet: 1
Gerrit-Owner: NyeonWoo Kim
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu shuo.liu@intel.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 14:09:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu shuo.liu@intel.com