Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69108 )
Change subject: cpu/x86/mp_init.c: Set a bogus initial lapic_id ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: uh oh, turns out hat this patch breaks things for me on an amd/mandolin:
[INFO ] CPU #0 initialized [INFO ] Initializing CPU #3 [INFO ] Initializing CPU #1 [INFO ] Initializing CPU #2 [EMERG] CPU: missing CPU device structureCPU: vendor AMD device 810f81 [DEBUG] CPU: family 17, model 18, stepping 01 [DEBUG] microcode: patch id to apply = 0x08108109 [INFO ] microcode: being updated to patch id = 0x08108109 succeeded [INFO ] CPU #1 initialized [ERROR] MP record 3 timeout. [INFO ] bsp_do_flight_plan done after 1206 msecs. [ERROR] MP initialization failure. [EMERG] mp_init_with_smm failed. Halting.
i'll see if things work again with the full patch train before reverting