Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44137 )
Change subject: soc/intel/skylake: acpi: drop HWP's dependency on EIST
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44137/3/src/soc/intel/skylake/acpi....
File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/44137/3/src/soc/intel/skylake/acpi....
PS3, Line 402: {
I'm not knowledgable about the coreboot coding standard, though in general I think it tries to avoid […]
right, but will be addressed in the follow-up anyways
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93d888ddce7b54e91b54e5b4fdd4d9cf16630eda
Gerrit-Change-Number: 44137
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Aug 2020 17:32:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Gerrit-MessageType: comment