build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/#/c/30414/13/src/drivers/spi/spi_winbond.h File src/drivers/spi/spi_winbond.h:
https://review.coreboot.org/#/c/30414/13/src/drivers/spi/spi_winbond.h@34 PS13, Line 34: #define CMD_W25_RES 0xab /* Release from DP, and Read Signature */ line over 80 characters
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/irqr... File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/irqr... PS13, Line 40: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/irqr... PS13, Line 62: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/w25q... File src/mainboard/facebook/fbg1701/w25q64.c:
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/w25q... PS13, Line 28: #define SPI_OPMENU_1 CMD_W25_PP /* BYPR: Byte Program */ please, no space before tabs
https://review.coreboot.org/#/c/30414/13/src/mainboard/facebook/fbg1701/w25q... PS13, Line 49: #define SPI_OPPREFIX CMD_W25_WREN /* WREN only to be inline */ please, no space before tabs
-
build bot (Jenkins) (Code Review)