Attention is currently required from: Arthur Heymans, Angel Pons, Jianjun Wang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62561 )
Change subject: device/mmio.h: Move readXp/writeXp helpers to device/mmio.h
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
```
src/include/device/mmio.h: In function 'read64p':
src/include/device/mmio.h:227:16: error: implicit declaration of function 'read64'; did you mean 'read64p'? [-Werror=implicit-function-declaration]
```
Seems like read* and write* is also only defined in x86 arch mmio.
File src/arch/x86/include/arch/mmio.h:
https://review.coreboot.org/c/coreboot/+/62561/comment/85338a42_e148e66f
PS2, Line 8: static __always_inline uint8_t read8(const volatile void *addr)
: {
: return *((volatile uint8_t *)(addr));
: }
we may also need to move these into the top mmio.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic13a94d91affb7cf65a2f22f08ea39ed671bc8e8
Gerrit-Change-Number: 62561
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 12:30:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment