HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'includ </arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/soc/intel/common/block/acpi/acpi.c M src/southbridge/intel/i82371eb/acpi_tables.c 17 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/1
diff --git a/src/mainboard/google/beltino/acpi_tables.c b/src/mainboard/google/beltino/acpi_tables.c index b6a5606..d2f7f45 100644 --- a/src/mainboard/google/beltino/acpi_tables.c +++ b/src/mainboard/google/beltino/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <ec/google/chromeec/ec.h> #include <southbridge/intel/lynxpoint/nvs.h> diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c index 50bd1e0..3e8cc20 100644 --- a/src/mainboard/google/jecht/acpi_tables.c +++ b/src/mainboard/google/jecht/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/google/parrot/acpi_tables.c b/src/mainboard/google/parrot/acpi_tables.c index ce03c70..62722ec 100644 --- a/src/mainboard/google/parrot/acpi_tables.c +++ b/src/mainboard/google/parrot/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/compal/ene932/ec.h> diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c index 507da97..c4c1788 100644 --- a/src/mainboard/google/rambi/acpi_tables.c +++ b/src/mainboard/google/rambi/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/google/slippy/acpi_tables.c b/src/mainboard/google/slippy/acpi_tables.c index d091931..ba55647 100644 --- a/src/mainboard/google/slippy/acpi_tables.c +++ b/src/mainboard/google/slippy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/stout/acpi_tables.c b/src/mainboard/google/stout/acpi_tables.c index 76342d4..08bd4cd 100644 --- a/src/mainboard/google/stout/acpi_tables.c +++ b/src/mainboard/google/stout/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <bootmode.h> diff --git a/src/mainboard/google/stout/onboard.h b/src/mainboard/google/stout/onboard.h index 6024ba8..a31dffd 100644 --- a/src/mainboard/google/stout/onboard.h +++ b/src/mainboard/google/stout/onboard.h @@ -3,8 +3,6 @@ #ifndef STOUT_ONBOARD_H #define STOUT_ONBOARD_H
-#include <arch/smp/mpspec.h> - #define STOUT_NIC_VENDOR_ID 0x10EC #define STOUT_NIC_DEVICE_ID 0x8168
diff --git a/src/mainboard/intel/baskingridge/acpi_tables.c b/src/mainboard/intel/baskingridge/acpi_tables.c index ba6d9c0..24edfea 100644 --- a/src/mainboard/intel/baskingridge/acpi_tables.c +++ b/src/mainboard/intel/baskingridge/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c index 013487f..36d0d66 100644 --- a/src/mainboard/intel/emeraldlake2/acpi_tables.c +++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 046d3ac..1351e62 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <cpu/x86/msr.h>
diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c index a3b9dd0..e97d9c1 100644 --- a/src/mainboard/intel/strago/acpi_tables.c +++ b/src/mainboard/intel/strago/acpi_tables.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/iomap.h> diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c index 960dbde..87cb965 100644 --- a/src/mainboard/intel/wtm2/acpi_tables.c +++ b/src/mainboard/intel/wtm2/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index 592ed50..aafbdb6 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <ec/acpi/ec.h> #if CONFIG(CHROMEOS) diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c index de2d51d..b66e4dd 100644 --- a/src/mainboard/samsung/stumpy/acpi_tables.c +++ b/src/mainboard/samsung/stumpy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 046d3ac..1351e62 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <cpu/x86/msr.h>
diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 70a9cac..02864b9 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -2,7 +2,6 @@
#include <acpi/acpigen.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <bootstate.h> #include <cbmem.h> #include <cf9_reset.h> diff --git a/src/southbridge/intel/i82371eb/acpi_tables.c b/src/southbridge/intel/i82371eb/acpi_tables.c index ab28e76..7507cd5 100644 --- a/src/southbridge/intel/i82371eb/acpi_tables.c +++ b/src/southbridge/intel/i82371eb/acpi_tables.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include "i82371eb.h"
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41669
to look at the new patch set (#2).
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'includ </arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/2
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41669
to look at the new patch set (#3).
Change subject: src: Remove unused 'includ <arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'includ <arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/3
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41669
to look at the new patch set (#4).
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'include <arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/4
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41669
to look at the new patch set (#5).
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'includ </arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/5
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
Patch Set 5: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG@7 PS5, Line 7: 'includ </arch/smp/mpspec.h>' um, this looks off... are you sure we have includ's? 😄
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'includ </arch/smp/mpspec.h>' ......................................................................
Patch Set 5:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG@7 PS5, Line 7: 'includ </arch/smp/mpspec.h>'
um, this looks off... […]
we should add one for sure lol
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41669
to look at the new patch set (#6).
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'include <arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41669/6
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
Patch Set 6:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41669/5//COMMIT_MSG@7 PS5, Line 7: 'includ </arch/smp/mpspec.h>'
we should add one for sure lol
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
src: Remove unused 'include <arch/smp/mpspec.h>'
Change-Id: If8048586e3693a8e6f63d9dc2800b073bab78628 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41669 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: David Guckian Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/onboard.h M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/southbridge/intel/i82371eb/acpi_tables.c 16 files changed, 0 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved David Guckian: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/beltino/acpi_tables.c b/src/mainboard/google/beltino/acpi_tables.c index b6a5606..d2f7f45 100644 --- a/src/mainboard/google/beltino/acpi_tables.c +++ b/src/mainboard/google/beltino/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <ec/google/chromeec/ec.h> #include <southbridge/intel/lynxpoint/nvs.h> diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c index 50bd1e0..3e8cc20 100644 --- a/src/mainboard/google/jecht/acpi_tables.c +++ b/src/mainboard/google/jecht/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/google/parrot/acpi_tables.c b/src/mainboard/google/parrot/acpi_tables.c index ce03c70..62722ec 100644 --- a/src/mainboard/google/parrot/acpi_tables.c +++ b/src/mainboard/google/parrot/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/compal/ene932/ec.h> diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c index 507da97..c4c1788 100644 --- a/src/mainboard/google/rambi/acpi_tables.c +++ b/src/mainboard/google/rambi/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/google/slippy/acpi_tables.c b/src/mainboard/google/slippy/acpi_tables.c index d091931..ba55647 100644 --- a/src/mainboard/google/slippy/acpi_tables.c +++ b/src/mainboard/google/slippy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/stout/acpi_tables.c b/src/mainboard/google/stout/acpi_tables.c index 76342d4..08bd4cd 100644 --- a/src/mainboard/google/stout/acpi_tables.c +++ b/src/mainboard/google/stout/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <bootmode.h> diff --git a/src/mainboard/google/stout/onboard.h b/src/mainboard/google/stout/onboard.h index 6024ba8..a31dffd 100644 --- a/src/mainboard/google/stout/onboard.h +++ b/src/mainboard/google/stout/onboard.h @@ -3,8 +3,6 @@ #ifndef STOUT_ONBOARD_H #define STOUT_ONBOARD_H
-#include <arch/smp/mpspec.h> - #define STOUT_NIC_VENDOR_ID 0x10EC #define STOUT_NIC_DEVICE_ID 0x8168
diff --git a/src/mainboard/intel/baskingridge/acpi_tables.c b/src/mainboard/intel/baskingridge/acpi_tables.c index ba6d9c0..24edfea 100644 --- a/src/mainboard/intel/baskingridge/acpi_tables.c +++ b/src/mainboard/intel/baskingridge/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c index 013487f..36d0d66 100644 --- a/src/mainboard/intel/emeraldlake2/acpi_tables.c +++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 046d3ac..1351e62 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <cpu/x86/msr.h>
diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c index a3b9dd0..e97d9c1 100644 --- a/src/mainboard/intel/strago/acpi_tables.c +++ b/src/mainboard/intel/strago/acpi_tables.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/iomap.h> diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c index 960dbde..87cb965 100644 --- a/src/mainboard/intel/wtm2/acpi_tables.c +++ b/src/mainboard/intel/wtm2/acpi_tables.c @@ -3,7 +3,6 @@ #include <types.h> #include <acpi/acpi.h> #include <arch/ioapic.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <soc/acpi.h> #include <soc/nvs.h> diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index 592ed50..aafbdb6 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <ec/acpi/ec.h> #if CONFIG(CHROMEOS) diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c index de2d51d..b66e4dd 100644 --- a/src/mainboard/samsung/stumpy/acpi_tables.c +++ b/src/mainboard/samsung/stumpy/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 046d3ac..1351e62 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -2,7 +2,6 @@
#include <types.h> #include <acpi/acpi.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include <cpu/x86/msr.h>
diff --git a/src/southbridge/intel/i82371eb/acpi_tables.c b/src/southbridge/intel/i82371eb/acpi_tables.c index ab28e76..7507cd5 100644 --- a/src/southbridge/intel/i82371eb/acpi_tables.c +++ b/src/southbridge/intel/i82371eb/acpi_tables.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> -#include <arch/smp/mpspec.h> #include <device/device.h> #include "i82371eb.h"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41669 )
Change subject: src: Remove unused 'include <arch/smp/mpspec.h>' ......................................................................
Patch Set 8:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4592 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4591 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4590 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4589
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
David Guckian (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)