Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Jitao Shi, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55779 )
Change subject: soc/mediatek/mt8195: Utilize the retry macro
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/soc/mediatek/mt8195/dptx.c:
https://review.coreboot.org/c/coreboot/+/55779/comment/f712d151_f70dc2b3
PS5, Line 186: if (cb_retry(7, dptx_hal_auxread_bytes(mtk_dp, cmd, dpcd_addr, length, data),
I think retry is more like original code flow.
Well... I'd prefer if we wrote code based on knowing how and why it works and not just on blindly copying stuff from elsewhere. But okay, no big deal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec95e20e5bb54fcd145007cc46f21c8b7e26d2
Gerrit-Change-Number: 55779
Gerrit-PatchSet: 8
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 24 Jun 2021 21:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment