Change in ...coreboot[master]: src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Mike Banon (Code Review)

30 Jun 2019 30 Jun '19

3:52 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33915

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments

These comments exist in some other buildOpts.c files, but not in this one.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33915/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 8ba5975..2a1f13d 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -43,8 +43,10 @@ #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h> #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>

+/* Select the CPU family. */ #define INSTALL_FAMILY_16_MODEL_0x_SUPPORT TRUE

+/* Select the CPU socket type. */ #define INSTALL_G34_SOCKET_SUPPORT FALSE #define INSTALL_C32_SOCKET_SUPPORT FALSE #define INSTALL_S1G3_SOCKET_SUPPORT FALSE @@ -165,6 +167,8 @@

#define BLDCFG_PLATFORM_CSTATE_OPDATA 0x1770

+// Specify the default values for the VRM controlling the VDDNB plane. +// If not specified, the values used for the core VRM will be applied #define BLDCFG_VRM_NB_CURRENT_LIMIT 13000 #define BLDCFG_VRM_NB_LOW_POWER_THRESHOLD 0 #define BLDCFG_VRM_SLEW_RATE 10000 @@ -344,4 +348,5 @@ #define DFLT_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED #define DFLT_VRM_SLEW_RATE (5000)

+/* AGESA nonsense: this header depends on the definitions above */ #include <PlatformInstall.h>

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Mike Banon (Code Review)

30 Jun 30 Jun

5:31 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 1:

am1i-a/buildOpts.c patch series [3/8] : 1st = CB:33913 , 2nd = CB:33914 ; 3rd = CB:33915 <-- you are here ; 4th = CB:33916 , 5th = CB:33917 , 6th = CB:33918 , 7th = CB:33919 , 8th = CB:33920

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 30 Jun 2019 15:31:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:49 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 1:

not sure if this is needed :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 30 Jun 2019 17:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

3 Jul 3 Jul

9:10 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 1:

...

Patch Set 1:

not sure if this is needed :)

More comments is usually good ;)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 03 Jul 2019 07:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

9 Apr 9 Apr

3:32 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33915

to look at the new patch set (#6).

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

mb/asus/am1i-a/buildOpts.c: return the removed comments

These comments exist in some other buildOpts.c files, but not in this one.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33915/6

Mike Banon (Code Review)

5:40 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 6:

Same SHA256 when built with "make BUILD_TIMELESS=1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 15:40:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10 Apr 10 Apr

1:32 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 6: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/33915/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33915/6//COMMIT_MSG@9 PS6, Line 9: some remove this word, so as to get the line under 72 chars?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 23:32:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

11 Apr 11 Apr

9:19 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33915

to look at the new patch set (#8).

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

mb/asus/am1i-a/buildOpts.c: return the removed comments

These comments exist in other buildOpts.c files, but not in this one. Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33915/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

9:21 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33915/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/33915/6//COMMIT_MSG@9 PS6, Line 9: some

...

remove this word, so as to get the line under 72 chars?

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Apr 2020 07:21:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Michał Żygowski (Code Review)

17 Apr 17 Apr

2:24 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33915/8/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:

https://review.coreboot.org/c/coreboot/+/33915/8/src/mainboard/asus/am1i-a/b... PS8, Line 157: // Specify the default values for the VRM controlling the VDDNB plane. Please keep the coreboot coding style for comments: https://doc.coreboot.org/coding_style.html#commenting

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 12:24:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

4:24 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33915

to look at the new patch set (#9).

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

mb/asus/am1i-a/buildOpts.c: return the removed comments

These comments exist in other buildOpts.c files, but not in this one. Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/33915/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 9 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

4:25 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33915/8/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:

https://review.coreboot.org/c/coreboot/+/33915/8/src/mainboard/asus/am1i-a/b... PS8, Line 157: // Specify the default values for the VRM controlling the VDDNB plane.

...

Please keep the coreboot coding style for comments: […]

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 9 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 14:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: comment

Michał Żygowski (Code Review)

4:40 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 9 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Apr 2020 14:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Apr 20 Apr

8:24 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: return the removed comments

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33915 )

Change subject: mb/asus/am1i-a/buildOpts.c: return the removed comments ......................................................................

mb/asus/am1i-a/buildOpts.c: return the removed comments

These comments exist in other buildOpts.c files, but not in this one. Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33915 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 7 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 28e502e..40950f6 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -31,8 +31,10 @@ #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h> #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>

+/* Select the CPU family. */ #define INSTALL_FAMILY_16_MODEL_0x_SUPPORT TRUE

+/* Select the CPU socket type. */ #define INSTALL_G34_SOCKET_SUPPORT FALSE #define INSTALL_C32_SOCKET_SUPPORT FALSE #define INSTALL_S1G3_SOCKET_SUPPORT FALSE @@ -152,6 +154,10 @@

#define BLDCFG_PLATFORM_CSTATE_OPDATA 0x1770

+/* + * Specify the default values for the VRM controlling the VDDNB plane. + * If not specified, the values used for the core VRM will be applied + */ #define BLDCFG_VRM_NB_CURRENT_LIMIT 13000 #define BLDCFG_VRM_NB_LOW_POWER_THRESHOLD 0 #define BLDCFG_VRM_SLEW_RATE 10000 @@ -331,4 +337,5 @@ #define DFLT_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED #define DFLT_VRM_SLEW_RATE (5000)

+/* AGESA nonsense: this header depends on the definitions above */ #include <PlatformInstall.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/33915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0aab06f1956bc0bf9f96d6176643c113a1e4cc5 Gerrit-Change-Number: 33915 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1678

days inactive

1973

days old

coreboot-gerrit@coreboot.org

13 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Michał Żygowski (Code Review)
Mike Banon (Code Review)
Patrick Georgi (Code Review)