Shuo Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81097?usp=email )
Change subject: drivers/intel/fsp2_0: Use DECLARE_REGION for FSP_SPEC_VIOLATION_ XEON_SP_HEAP_WORKAROUND ......................................................................
drivers/intel/fsp2_0: Use DECLARE_REGION for FSP_SPEC_VIOLATION_ XEON_SP_HEAP_WORKAROUND
Fixes: 0201d98("drivers/intel/fsp: Work around multi-socket Xeon-SP pipe init bug")
Change-Id: I5f7d7855592d99b074f7ef49c285a13f8105f089 Signed-off-by: Shuo Liu shuo.liu@intel.com --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/81097/1
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c index c096e86..3f75770 100644 --- a/src/drivers/intel/fsp2_0/memory_init.c +++ b/src/drivers/intel/fsp2_0/memory_init.c @@ -172,10 +172,9 @@
if (CONFIG(FSP_USES_CB_STACK) && ENV_RAMINIT && CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) { - extern char _fspm_heap[]; - extern char _efspm_heap[]; + DECLARE_REGION(fspm_heap); arch_upd->StackBase = (uintptr_t)_fspm_heap; - arch_upd->StackSize = (size_t)(_efspm_heap - _fspm_heap); + arch_upd->StackSize = (size_t)REGION_SIZE(fspm_heap); } else if (CONFIG(FSP_USES_CB_STACK) || !ENV_CACHE_AS_RAM) { arch_upd->StackBase = (uintptr_t)temp_ram; arch_upd->StackSize = sizeof(temp_ram);