Change in coreboot[master]: mb/google/dedede/var/lantis: Config i2c high and low time for touchpad
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48867 )
Change subject: mb/google/dedede/var/lantis: Config i2c high and low time for touchpad ......................................................................
mb/google/dedede/var/lantis: Config i2c high and low time for touchpad
BUG=b:173709409 BRANCH=dedede TEST=EE measured result is 390.8kHZ
Change-Id: I7a6475fd29d4c9f8efa78a42a112b5565511b939 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/lantis/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/48867/1
diff --git a/src/mainboard/google/dedede/variants/lantis/overridetree.cb b/src/mainboard/google/dedede/variants/lantis/overridetree.cb index 1b87bcb..f2b27c2 100644 --- a/src/mainboard/google/dedede/variants/lantis/overridetree.cb +++ b/src/mainboard/google/dedede/variants/lantis/overridetree.cb @@ -33,6 +33,12 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 187, + .scl_hcnt = 95, + .sda_hold = 40, + } }, .i2c[2] = { .speed = I2C_SPEED_FAST,
Tony Huang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/48867 )
Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchpad ......................................................................
mb/google/dedede/var/lantis: Config I2C high and low time for touchpad
BUG=b:173709409 BRANCH=dedede TEST=EE measured result is 390.8kHZ
Change-Id: I7a6475fd29d4c9f8efa78a42a112b5565511b939 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/lantis/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/48867/2
Hello build bot (Jenkins), Henry Sun, Wisley Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48867
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchpad ......................................................................
mb/google/dedede/var/lantis: Config I2C high and low time for touchpad
BUG=b:173709409 BRANCH=dedede TEST=EE measured result is 390.8kHZ
Change-Id: I7a6475fd29d4c9f8efa78a42a112b5565511b939 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/lantis/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/48867/3
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48867 )
Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchpad ......................................................................
Patch Set 3: Code-Review+2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48867 )
Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchpad ......................................................................
Patch Set 3:
Hi Karthik, Could you please help merge this CL? Thanks
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48867 )
Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchpad ......................................................................
mb/google/dedede/var/lantis: Config I2C high and low time for touchpad
BUG=b:173709409 BRANCH=dedede TEST=EE measured result is 390.8kHZ
Change-Id: I7a6475fd29d4c9f8efa78a42a112b5565511b939 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48867 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/lantis/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/lantis/overridetree.cb b/src/mainboard/google/dedede/variants/lantis/overridetree.cb index 1b87bcb..1f53311 100644 --- a/src/mainboard/google/dedede/variants/lantis/overridetree.cb +++ b/src/mainboard/google/dedede/variants/lantis/overridetree.cb @@ -33,6 +33,12 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 185, + .scl_hcnt = 95, + .sda_hold = 40, + } }, .i2c[2] = { .speed = I2C_SPEED_FAST,
-
Karthik Ramasubramanian (Code Review) -
Tony Huang (Code Review)