Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84395?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/samsung/lumpy: Correct number of jacks in hda_verb.c ......................................................................
mb/samsung/lumpy: Correct number of jacks in hda_verb.c
The verb data was not aligned to a multiple of 4, therefore an entry was repeated as padding. This has not been tested.
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: I3a40e6229419ee7d1a238916ee6d49cf9314f6ab Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/84395 Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/samsung/lumpy/hda_verb.c 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c index d18d8d2..b3350a1 100644 --- a/src/mainboard/samsung/lumpy/hda_verb.c +++ b/src/mainboard/samsung/lumpy/hda_verb.c @@ -6,12 +6,15 @@ /* coreboot specific header */ 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 0x152D0924, // Subsystem ID - 0x00000007, // Number of jacks + 0x00000008, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */ AZALIA_SUBVENDOR(0, 0x152D0924),
0x00170500, + 0x00170500, /* Padding */ + 0x00170500, /* Padding */ + 0x00170500, /* Padding */
/* Pin Widget Verb Table */