Attention is currently required from: Tony Huang, Robert Chen, Karthik Ramasubramanian.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62002 )
Change subject: mb/google/dedede/var/lantis: Add ELAN touchscreen driver
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
File src/mainboard/google/dedede/variants/lantis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62002/comment/b06260a4_f0e93573
PS11, Line 7: TP_DRIVER_INTERFACE 43 45
May I ask where these bits are confirmed allocated or defined? Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23d3de5e45aa2876c1590a1e09679d652a3f2906
Gerrit-Change-Number: 62002
Gerrit-PatchSet: 11
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 05 Mar 2022 07:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment