Attention is currently required from: Martin Roth, Andrey Petrov, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52867 )
Change subject: drivers/intel/fsp2_0: Add timestamps for loading FSPM & FSPS
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52867/comment/275140c8_95b65c31
PS1, Line 15: timestamps.
Can you please add a snippet of the timestamps here?
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/52867/comment/216d58a6_63270893
PS1, Line 122: INITRAM
MEMORY_INIT to keep it consistent with TS_FSP_MEMORY_INIT_START and TS_FSP_MEMORY_INIT_END
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5796d4cdd512799c2eafee45a8ef561de5258b91
Gerrit-Change-Number: 52867
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 03 May 2021 23:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment