Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64871 )
Change subject: cpu/amd: Move locking SMM as part of SMM init
......................................................................
Patch Set 23:
(1 comment)
Patchset:
PS23:
FYI, this breaks S3 resume on Stoney:
[DEBUG] S3 Resume
[DEBUG] agesawrapper_amds3laterestore() entry
[DEBUG] FMAP: area COREBOOT found @ 54200 (16432640 bytes)
[INFO ] CBFS: Found 'AGESA' @0xdabdc0 size 0x67564 in mcache @0xbf7dd2e4
[DEBUG] Error: Can't find 57a9e200 raw data to imd
[ERROR] S3 volatile data not found
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9
Gerrit-Change-Number: 64871
Gerrit-PatchSet: 23
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 31 Jan 2023 22:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment