Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 24:
(352 comments)
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e38783d_1c1264db PS24, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0ed5a27f_340c3156 PS24, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/89fced39_6beb23ec PS24, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8b4225d8_6de6e541 PS24, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9796458b_6f80bb27 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/65d89890_d84820c0 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/36499586_58ddbe65 PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c16e07b9_a0710a8d PS24, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/798a4ea4_2d43cbd0 PS24, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/915c7513_c7e79231 PS24, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dbfa2278_4beab7e2 PS24, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dee5f3bf_99fbabfb PS24, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3a6188b0_7bf50154 PS24, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7d209eac_0d416614 PS24, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9565db7d_59c919f6 PS24, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2ead3725_614a131e PS24, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/928d26ac_35e90ebf PS24, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/621d7977_c5477581 PS24, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f3544ca4_5833fdb5 PS24, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0651d365_53c4c305 PS24, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3db74c_a2d8aa17 PS24, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d98c2f4d_2d18060e PS24, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/557e4821_d0e1e845 PS24, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/257cf41a_e07ddc78 PS24, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/545aa950_70b4e6c7 PS24, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d632bcf3_7e7c7c6c PS24, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5caca82f_9c7663a8 PS24, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fad30d69_3d15ecf5 PS24, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f655ef_55d204f7 PS24, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d536a4a2_1d4b184b PS24, Line 206: trailing whitespace
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1d4a892_d1c264fd PS24, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e9e0d954_682feee2 PS24, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fd66594b_1cad36e2 PS24, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/79001224_da7a60db PS24, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/78344eff_003f8038 PS24, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10e723a0_03bddcfe PS24, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff56fd24_2be94549 PS24, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ea48d57_00e4256b PS24, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/62512e6b_89226041 PS24, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d20e3dcd_bde50cf4 PS24, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/048f3809_55e4e4a1 PS24, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/91c20080_3fc6577c PS24, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1d6aee5b_50812ea2 PS24, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e9175a8_65e9a1b9 PS24, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/696061a7_366bf43b PS24, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/004bb69a_a7bcbd9f PS24, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/532e6982_cbae602a PS24, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8b1b22b9_de134138 PS24, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3bf69cdc_7177e5d2 PS24, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bbef7aaf_f00feeef PS24, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/56ed2cf0_6fc8d218 PS24, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/54451d4f_4f1fa73c PS24, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d5150ef3_33bbae31 PS24, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/233e670c_32e2759e PS24, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/faf71aee_b6933fe3 PS24, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/28b115ac_b3488b29 PS24, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/651ec5ca_2bac63bf PS24, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1a509bf0_5d3a5c44 PS24, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d6704467_e9b816cb PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/919e0344_32e88ced PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/086ffa8b_c2ac8d5c PS24, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1dfaaef0_03d350ab PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc511bd8_a06a4014 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc5a0edc_81f6e5d2 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10736e99_b975d6c5 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/71693235_caaf7807 PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/62adc979_86512e5e PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c14b33e3_57a9821d PS24, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/65555cd9_5ac4b8d3 PS24, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b37ec385_a62fa2e2 PS24, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9bf9788_386aeb9e PS24, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/20ed71c1_5f41fe13 PS24, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bce203e0_6360db46 PS24, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c5251301_7ea64972 PS24, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b59a3c7a_bc1bdb37 PS24, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cea3e7d3_5c411caf PS24, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a1a5b99a_87010600 PS24, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9330221c_bc6251b8 PS24, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/79c6f384_e0b4edac PS24, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0162a747_2d688249 PS24, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bffd749e_949126c6 PS24, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3553e7_5fb5eb44 PS24, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f508ea8c_f94aa47a PS24, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a70060ea_98660721 PS24, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6214be3e_0b63634f PS24, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ac29e781_7508bde4 PS24, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a7aba15e_8abb745b PS24, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/478ffcd2_923118b5 PS24, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6f65c2c6_7a521092 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1b529c5a_61a09890 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/14b9108a_ba491db4 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eea3648f_a6d956ae PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc1507d8_61d1c174 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/20024a82_00225e98 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e7a453b8_77269467 PS24, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08bf1116_a242b63d PS24, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/78bf54d7_dcaef26f PS24, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b35d09d4_93651ede PS24, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1668966f_fafce36e PS24, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d3f06681_bbfa8114 PS24, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e805b3f8_4262eca3 PS24, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8fca728f_9efe9a81 PS24, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5a0742be_5878332b PS24, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c0e1dd22_ed700515 PS24, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/25333885_39fc7dd0 PS24, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ef8caeab_9d547db9 PS24, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a70910e0_0651d766 PS24, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eade4970_d788990d PS24, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cca2b19a_375dba33 PS24, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/babccf04_3917dc1b PS24, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ebc6e5_b921b615 PS24, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/87f739b1_b4300c15 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5249bc89_540090b5 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/22414148_43e7fd2a PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/23a522b5_802b9416 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8d6ed14_faf80cb9 PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/414277d3_f7a2047d PS24, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/39de8428_b006fa7e PS24, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/299d292a_0bf6309a PS24, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/710e4d8d_8d228108 PS24, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/75a19f78_fdeb9843 PS24, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/874947ab_74c3b291 PS24, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cbf1ce92_c1a0ad46 PS24, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5d6463b8_00a97f77 PS24, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9693588e_f6809095 PS24, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/52c39535_cbe8d506 PS24, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7dd3d2d2_d615b2e2 PS24, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7a57353b_1e401b7a PS24, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ed07d85a_2496c0a4 PS24, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9be81b21_56365aba PS24, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac896b8_e3ff5712 PS24, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6983f251_f703e6d6 PS24, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a6229193_d6fab790 PS24, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6b69ca0a_8714e173 PS24, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7f53be0e_18777a90 PS24, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e84fecf1_0e446f62 PS24, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cd42ad6e_4032a004 PS24, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9bea95e_c550c985 PS24, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1b8147db_92ea0a99 PS24, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/57c10ea2_be3db64f PS24, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/55e16cf4_7c805aa3 PS24, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/580ed7b5_59b89b88 PS24, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/86d290b0_90e129cb PS24, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/121ccb8e_ea8592e8 PS24, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b8726ed0_6fc16876 PS24, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5fb92b7a_0c14b555 PS24, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/40a2a42f_87a36b9c PS24, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9d6c16a6_bd179880 PS24, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7f9148_8748a40b PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/795bdd2d_1bacbc7d PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/41a00749_4108f194 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5e75a550_2c55c777 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8cb0dc4_f6ae9668 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a69ac13d_b7e9f4b5 PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d110437d_d0c099eb PS24, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8adffcb7_95b4c025 PS24, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc00ab57_c384ebec PS24, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e4e9583f_ad8a7c84 PS24, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8dc89149_51c0a93f PS24, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1d34af55_25089d72 PS24, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a394a062_7c20c13a PS24, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e4d03aa7_7f3052d6 PS24, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/771fccd6_d749bf86 PS24, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ce7b9c90_c4d84d70 PS24, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b4dac010_a59dcbde PS24, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8021c4f4_561d3568 PS24, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b7b72738_6d04b38b PS24, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/835d4457_ef9dc0aa PS24, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b031a064_aea5ec1f PS24, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f0666095_df93f6a3 PS24, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7e153ce9_6d5b7fa0 PS24, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f4c0d3e_4e8e5ba7 PS24, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4ff6cf89_7f2cacce PS24, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4092453d_540a24ed PS24, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3e5f7f03_95852fdc PS24, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/03c9bb3d_8b7c41e8 PS24, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/de858e67_a5563292 PS24, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc99a6ec_b895d7e1 PS24, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/24480617_616c13ac PS24, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/d9bfefad_9359fe8b PS24, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8d0daf8f_618e9afc PS24, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/df3953c1_51d17b4d PS24, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5479d51f_77f5e3f1 PS24, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fae472ea_234d1d68 PS24, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e481df12_fd0820b6 PS24, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a89674ea_f6e3aaeb PS24, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1ca2f421_a3ad1f1a PS24, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/40732f0d_9d9bdeb1 PS24, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff078fe3_05c8f00d PS24, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7d900b7f_6535dad2 PS24, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9463b51b_1a490d3a PS24, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/421c98de_a5d88789 PS24, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/104c2f21_ba03f77d PS24, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/874e1e67_bb334361 PS24, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51beb92d_8c05820e PS24, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3b5db442_5e12ca60 PS24, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2a59c941_5b47ce75 PS24, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/252cfb3c_a2ccfc52 PS24, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/99769905_d1c828dc PS24, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/407ca5b9_248344f2 PS24, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be71b6f9_44bbb364 PS24, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8cc55c52_6032b54c PS24, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cc2ba9c8_6d19a6c8 PS24, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9ee5c18c_e04f8860 PS24, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e8337e7e_13e10f91 PS24, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a361365d_8bcf50f5 PS24, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e2d96756_c4c53631 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dd547cce_e6184e1c PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e3225678_509ac332 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5801d696_4da6f223 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6a9b69fd_bf6eff67 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/55c6e0a7_f733d028 PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4e7d74b7_99c8a7ec PS24, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5da5cb22_91b88212 PS24, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3c4dbdbf_9f6f581e PS24, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/72ab4ef7_418caa43 PS24, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a5600a38_cd9c1a69 PS24, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc5f745b_a93af4b2 PS24, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0044bbac_7f7ae34b PS24, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/11778035_ebf73d80 PS24, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1351edea_c8ae1fab PS24, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08da48f0_7c374092 PS24, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a09cc523_5d906421 PS24, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e50e7281_df75db8f PS24, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/34ecb2fd_4b290c76 PS24, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/453fde74_73031e7c PS24, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4228a882_6657a5e9 PS24, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/46205348_d7267d14 PS24, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c5a86090_4e9a7b05 PS24, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/169ed215_9b418327 PS24, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/09fa843a_c845d376 PS24, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f63a0f68_9c8885b6 PS24, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/87050930_99f5f72a PS24, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f23dfcb_69db4f11 PS24, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0a5d4962_0d82acaf PS24, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bdfe9d41_bc948149 PS24, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/11aac793_3dd984d0 PS24, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/25fd77e1_086e3e38 PS24, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c91ba5dd_27d98511 PS24, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51251d93_89b3561a PS24, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b270377c_51be4997 PS24, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/abe967c0_0b36fd32 PS24, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be80276e_9ef86d63 PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/acad3277_e4f9be8f PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7b4d8f_bb443885 PS24, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cb6c5c1e_1e4ac1de PS24, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/81be134f_4c136c27 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/15d2cf08_51f72600 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e7960e0b_83646bfc PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0d69a70f_b3b24f97 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf9b1c94_d63ceab7 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cb3125d4_d1057466 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c694960_cc0db8d4 PS24, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8e3ae5b6_49cba184 PS24, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0321f940_ee348d02 PS24, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/050015ee_8e8ccb21 PS24, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/10bb0c9b_2d3fce27 PS24, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8a611363_34a5ce42 PS24, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/89456f75_711ce14a PS24, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5969433e_893b859b PS24, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8f1177e0_20bf2519 PS24, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/29fb51e3_53d85dcb PS24, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/80dada21_09e9a83f PS24, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1f1befdf_6d6d9aab PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f091edb8_1cf5defc PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/be112a27_b4d7b1af PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3d615f67_05ffbf74 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dea30921_339f2fd4 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/891f7497_031625f3 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f90f8688_3f3217dd PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f067bf61_43e49151 PS24, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/09b06260_bdaee195 PS24, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4feaacf8_97b815c0 PS24, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c2c7857b_00a69378 PS24, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/0a232731_5847a915 PS24, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf7a2771_2f241924 PS24, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c3701803_9db9b7e5 PS24, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/53e89f70_30b785f2 PS24, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/75152048_09fa0a85 PS24, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc2cd0e8_69cfa069 PS24, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3e87c49e_90e5a88d PS24, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3021a4fa_9c6e341f PS24, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7a7128_4236186b PS24, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/326ba743_7a930e20 PS24, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c3d8dbd9_61797775 PS24, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/660876e6_42b207a0 PS24, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/482c81a3_458dee1e PS24, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f1be12c6_4abd2ec6 PS24, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9a857403_306eac8f PS24, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51396f28_dbc46ea2 PS24, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b982c7ff_4e708297 PS24, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/01933616_a30ac23b PS24, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7843c3e4_9aa20af6 PS24, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6ee5adbb_43a91ac9 PS24, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9f1f11ac_ac46a36c PS24, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bf7c4b9e_f94d52b1 PS24, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/5e657a1e_f26f86b1 PS24, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/eb709f2d_84084fc1 PS24, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f677f167_2f03cad5 PS24, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f58f9624_1be538ca PS24, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/59826e3e_7ca3e122 PS24, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/834bcf85_98e8e255 PS24, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c22ab672_e92a94d7 PS24, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/7ae222b5_df9b9301 PS24, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/26bc54f3_4681c2e5 PS24, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6e9bbcb1_2f417af6 PS24, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4df2c0f5_a117de32 PS24, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c27e0bd8_14bf9cef PS24, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1a5f04a6_9ddab089 PS24, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8ead8c53_9eb61eca PS24, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/61f388ac_541e043d PS24, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/3f6a5a32_864f7f3e PS24, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f439a76b_f222a02d PS24, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e0bf50b2_bc3cd814 PS24, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1eca27b0_f1c5b191 PS24, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9b19da99_baf69bdf PS24, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/13e71c67_f7ebad51 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/61e54530_6cb68da7 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/bc8345b1_11e5d5b3 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/197e6b97_3841ec30 PS24, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a9f11ff8_b7d973bb PS24, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c49d3996_a68d09da PS24, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/8a1dff13_32cfa768 PS24, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/dc6cab1e_9464a377 PS24, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/455f8274_fcadc152 PS24, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a6e769ea_e91c8648 PS24, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/db05a9b3_cfdbbc26 PS24, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/cce6a26f_714d17af PS24, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9dcab284_51c75b3a PS24, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/da0bb3a0_2d2b2de9 PS24, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/e544fb41_38486962 PS24, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/f4db3a95_c1b94141 PS24, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/076b20b8_ec1a0b1c PS24, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/b759aa12_8cf08e10 PS24, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/a277834b_ea816ec6 PS24, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/494ebb81_d56fcd00 PS24, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/c14da000_4b82f34f PS24, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4b431ba3_33cddabd PS24, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/4f4713c7_99764895 PS24, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/272016d4_203eaa70 PS24, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/354123d8_ee5c3192 PS24, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/fbe74f1a_a05b4128 PS24, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/2059ff76_d8c044bf PS24, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/51dd3ad7_1728e52b PS24, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/ff642418_cae66e72 PS24, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/08c6febf_87427e8b PS24, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/1c66a4d9_8a93a587 PS24, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/31dfa008_f447a8bb PS24, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/6965b4b5_e9a2cef9 PS24, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/84933389_45150ec7 PS24, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/740ccfea_517910a8 PS24, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132358): https://review.coreboot.org/c/coreboot/+/58854/comment/9feb466c_564a4df2 PS24, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
-
build bot (Jenkins) (Code Review)