Attention is currently required from: Andy Hsu, Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/ee1c5d50_60abfa6a?usp... :
PS7, Line 204: Failed to parse load buffer
Buffer size too small
https://review.coreboot.org/c/coreboot/+/85654/comment/65dff507_ebd8f260?usp... :
PS7, Line 233: {
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alvin Liu
alvin.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 06 Jan 2025 06:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes