Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39020 )
Change subject: mb/google/drallion: Remove MAC address pass through ......................................................................
mb/google/drallion: Remove MAC address pass through
Remove MAC address pass through because when MAC address pass through setting change to "Use dock built-in MAC address", the MAC address always keeps the VPD value.
BUG=b:147994020 TEST=tested on drallion and the result as below. (Option) (Result) - Use pre-assigned MAC address : Pass - Use Chromebook built-in address : Pass - Use dock built-in MAC address : Pass
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I1f58e98187feb4e428ca75f7e82c464567528526 --- M src/mainboard/google/drallion/dsdt.asl 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/39020/1
diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl index ee63d6e..33ede7a 100644 --- a/src/mainboard/google/drallion/dsdt.asl +++ b/src/mainboard/google/drallion/dsdt.asl @@ -48,8 +48,6 @@ #include <vendorcode/google/chromeos/acpi/chromeos.asl> /* VPD support */ #include <vendorcode/google/chromeos/acpi/vpd.asl> - /* MAC address passthru */ - #include <vendorcode/google/chromeos/acpi/amac.asl> #endif
#include <southbridge/intel/common/acpi/sleepstates.asl>
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39020 )
Change subject: mb/google/drallion: Remove MAC address pass through ......................................................................
Patch Set 1: Code-Review+2
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39020 )
Change subject: mb/google/drallion: Remove MAC address pass through ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39020 )
Change subject: mb/google/drallion: Remove MAC address pass through ......................................................................
mb/google/drallion: Remove MAC address pass through
Remove MAC address pass through because when MAC address pass through setting change to "Use dock built-in MAC address", the MAC address always keeps the VPD value.
BUG=b:147994020 TEST=tested on drallion and the result as below. (Option) (Result) - Use pre-assigned MAC address : Pass - Use Chromebook built-in address : Pass - Use dock built-in MAC address : Pass
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I1f58e98187feb4e428ca75f7e82c464567528526 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39020 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/dsdt.asl 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl index ee63d6e..33ede7a 100644 --- a/src/mainboard/google/drallion/dsdt.asl +++ b/src/mainboard/google/drallion/dsdt.asl @@ -48,8 +48,6 @@ #include <vendorcode/google/chromeos/acpi/chromeos.asl> /* VPD support */ #include <vendorcode/google/chromeos/acpi/vpd.asl> - /* MAC address passthru */ - #include <vendorcode/google/chromeos/acpi/amac.asl> #endif
#include <southbridge/intel/common/acpi/sleepstates.asl>
-
Dtrain Hsu (Code Review) -
EricR Lai (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)