Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44438
to review the following change.
Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants/casta: Disable xHCI compliance mode
Disable xHCI compliance mode to prevent SS hub detection issue.
BRANCH=firmware-octopus-11297.B BUG=none TEST=built
Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44438/1
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index 2f2f80b..3f2a884 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -139,4 +139,7 @@ end end # - I2C 6 end + + # Disable compliance mode + register "DisableComplianceMode" = "1" end
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44438 )
Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44438 )
Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44438 )
Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode ......................................................................
mb/google/octopus/variants/casta: Disable xHCI compliance mode
Disable xHCI compliance mode to prevent SS hub detection issue.
BRANCH=firmware-octopus-11297.B BUG=none TEST=built
Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44438 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index 2f2f80b..3f2a884 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -139,4 +139,7 @@ end end # - I2C 6 end + + # Disable compliance mode + register "DisableComplianceMode" = "1" end