Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63946 )
Change subject: mb/intel/adlrvp: disable unused root port 1, 3, 4 for Adl-P RVP
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63946/comment/edabfdff_b4e77915
PS5, Line 429: device ref pcie_rp3 on end # W/A to FSP issue
: device ref pcie_rp4 on end # W/A to FSP issue
the comment says WA for FSP issue. […]
This was ported to start with initially, probably ported from ADL-M RVP (src/mainboard/intel/adlrvp/devicetree_m.cb). There is no specific changes just for these two lines. It also results in warning messages in PCIe clock assignment. I tested and I didn't run into any problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I322280ab02361e3a2a5925d69f33b23453d36dbf
Gerrit-Change-Number: 63946
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 21:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-MessageType: comment