Change in coreboot[master]: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support

List overview All Threads
Download

newer

older

Change in coreboot[master]: lint:...

Change in coreboot[master]:...

Kevin Chiu (Code Review)

18 Sep 2020 18 Sep '20

6:32 a.m.

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support

Add THERMCTL_LIMIT (die temperature limit) DPTC parameter for clamshell/tablet mode.

BUG=b:157943445 BRANCH=master TEST=build

Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/soc/amd/picasso/chip.h M src/soc/amd/picasso/root_complex.c 2 files changed, 11 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45519/1

diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 1167509..8fe5269 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -97,6 +97,7 @@ uint32_t fast_ppt_limit_tablet_mode; uint32_t slow_ppt_limit_tablet_mode; uint32_t sustained_power_limit_tablet_mode; + uint32_t thermctl_limit_tablet_mode;

/* PROCHOT_L de-assertion Ramp Time */ uint32_t prochot_l_deassertion_ramp_time; diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 6c721e1..9c94b07 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -17,10 +17,11 @@

enum { ALIB_DPTCI_FUNCTION_ID = 0xc, + THERMAL_CONTROL_LIMIT_ID = 0x3, SUSTAINED_POWER_LIMIT_PARAM_ID = 0x5, FAST_PPT_LIMIT_PARAM_ID = 0x6, SLOW_PPT_LIMIT_PARAM_ID = 0x7, - DPTC_TOTAL_UPDATE_PARAMS = 3, + DPTC_TOTAL_UPDATE_PARAMS = 4, };

struct dptc_param { @@ -33,11 +34,15 @@ struct dptc_param params[DPTC_TOTAL_UPDATE_PARAMS]; } __packed;

-#define DPTC_INPUTS(_sustained, _fast, _slow) \ +#define DPTC_INPUTS(_thermctllmit, _sustained, _fast, _slow) \ { \ .size = sizeof(struct dptc_input), \ .params = { \ { \ + .id = THERMAL_CONTROL_LIMIT_ID, \ + .value = _thermctllmit, \ + }, \ + { \ .id = SUSTAINED_POWER_LIMIT_PARAM_ID, \ .value = _sustained, \ }, \ @@ -195,10 +200,12 @@ if (!config->dptc_enable) return;

- struct dptc_input default_input = DPTC_INPUTS(config->sustained_power_limit, + struct dptc_input default_input = DPTC_INPUTS(config->thermctl_limit, + config->sustained_power_limit, config->fast_ppt_limit, config->slow_ppt_limit); struct dptc_input tablet_mode_input = DPTC_INPUTS( + config->thermctl_limit_tablet_mode, config->sustained_power_limit_tablet_mode, config->fast_ppt_limit_tablet_mode, config->slow_ppt_limit_tablet_mode);

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

build bot (Jenkins) (Code Review)

18 Sep 18 Sep

6:32 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/root_co... PS1, Line 37: #define DPTC_INPUTS(_thermctllmit, _sustained, _fast, _slow) \ line over 96 characters

Aaron Durbin (Code Review)

11:46 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h@... PS1, Line 100: uint32_t thermctl_limit_tablet_mode; Should we move this to around line 114 so the 2 configs are closer to one another?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Sep 2020 14:46:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

12:17 p.m.

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Keith Tzeng, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45519

to look at the new patch set (#2).

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support

Add THERMCTL_LIMIT (die temperature limit) DPTC parameter for clamshell/tablet mode.

BUG=b:157943445 BRANCH=master TEST=build

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45519/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

12:17 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... PS2, Line 37: #define DPTC_INPUTS(_thermctllmit, _sustained, _fast, _slow) \ line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Sep 2020 15:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

12:18 p.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/45519/1/src/soc/amd/picasso/chip.h@... PS1, Line 100: uint32_t thermctl_limit_tablet_mode;

...

Should we move this to around line 114 so the 2 configs are closer to one another?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Sep 2020 15:18:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

20 Sep 20 Sep

12:34 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/45519/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45519/2//COMMIT_MSG@13 PS2, Line 13: master zork

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... PS2, Line 37: Drop some tabs to bring the character count < 96 characters?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 20 Sep 2020 15:34:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kevin Chiu (Code Review)

1:08 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Keith Tzeng, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45519

to look at the new patch set (#3).

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support

Add THERMCTL_LIMIT (die temperature limit) DPTC parameter for clamshell/tablet mode.

BUG=b:157943445 BRANCH=zork TEST=build

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45519/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

1:09 p.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45519/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45519/2//COMMIT_MSG@13 PS2, Line 13: master

...

zork

Done

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/45519/2/src/soc/amd/picasso/root_co... PS2, Line 37:

...

Drop some tabs to bring the character count < 96 characters?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 20 Sep 2020 16:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:24 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 20 Sep 2020 17:24:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:24 p.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support

Add THERMCTL_LIMIT (die temperature limit) DPTC parameter for clamshell/tablet mode.

BUG=b:157943445 BRANCH=zork TEST=build

Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45519 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/picasso/chip.h M src/soc/amd/picasso/root_complex.c 2 files changed, 11 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 1167509..9c9ae7f 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -111,6 +111,7 @@

/* Lower die temperature limit */ uint32_t thermctl_limit; + uint32_t thermctl_limit_tablet_mode;

/* FP5 Processor Voltage Supply PSI Currents. 0 indicates use SOC default */ uint32_t psi0_current_limit; diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 6c721e1..174cddc 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -17,10 +17,11 @@

struct dptc_param { @@ -33,11 +34,15 @@ struct dptc_param params[DPTC_TOTAL_UPDATE_PARAMS]; } __packed;

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

3:10 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45519 )

Change subject: soc/amd/picasso: Add THERMCTL_LIMIT DPTC parameter support ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/20092 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20091 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/20090 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20089 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/20088 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/20096 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/20095 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/20094 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/20093

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id193a74210c92d1e45ed4824ee9c0fc9ceaa5e3a Gerrit-Change-Number: 45519 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Sun, 20 Sep 2020 18:10:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1676

days inactive

1678

days old

coreboot-gerrit@coreboot.org

11 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Aaron Durbin (Code Review)
build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Kevin Chiu (Code Review)