Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE ......................................................................
soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE
Increase the cbmem console size in order to fix console overflow.
Change-Id: Id7eb64feb91ec29df5402b2fb1bac3ff73cc5bb3 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/44326/1
diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index f2922f5..7321425 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -209,5 +209,5 @@
config PRERAM_CBMEM_CONSOLE_SIZE hex - default 0xe00 + default 0x1400 endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG@10 PS1, Line 10: overflow. Please give the exact values. Increase the value from … KB to … KB.
Additionally, it’d be great, if you mentioned what other devices already use that value.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE ......................................................................
Patch Set 1:
(1 comment)
Thanks for addressing the console buffer overflow.
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG@10 PS1, Line 10: overflow.
Please give the exact values. Increase the value from … KB to … KB. […]
It seems Tigerlake also uses the same cbmem console size. Could that also be experiencing console buffer overflow?
Hello build bot (Jenkins), Maulik V Vaghela, Angel Pons, Aamir Bohra, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44326
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB
Increase the cbmem console size from 3KB to 5KB in order to fix console overflow.
Change-Id: Id7eb64feb91ec29df5402b2fb1bac3ff73cc5bb3 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/44326/2
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44326/1//COMMIT_MSG@10 PS1, Line 10: overflow.
It seems Tigerlake also uses the same cbmem console size. […]
Yes, Karthik. There is already an active patch for Tigerlake addressing the same issue. https://review.coreboot.org/c/coreboot/+/43666
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 2: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44326 )
Change subject: soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
soc/intel/jasperlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB
Increase the cbmem console size from 3KB to 5KB in order to fix console overflow.
Change-Id: Id7eb64feb91ec29df5402b2fb1bac3ff73cc5bb3 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44326 Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aamir Bohra: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved Angel Pons: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index f2922f5..7321425 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -209,5 +209,5 @@
config PRERAM_CBMEM_CONSOLE_SIZE hex - default 0xe00 + default 0x1400 endif
-
Aamir Bohra (Code Review) -
Angel Pons (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Meera Ravindranath (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)